Bug 1889522

Summary:	metrics playbooks are broken due to typo
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Guilherme Santos <gdeolive>
Component:	ovirt-engine-metrics	Assignee:	Shirly Radco <sradco>
Status:	CLOSED ERRATA	QA Contact:	Guilherme Santos <gdeolive>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	aoconnor, michal.skrivanek
Target Milestone:	ovirt-4.4.3	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-metrics-1.4.2-1.el8ev	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-24 13:10:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Guilherme Santos 2020-10-19 20:32:08 UTC

Description of problem:
manage-ovirt-metrics-services.yml and cleanup-ovirt-metrics playbook are failing due to typo on line 63 here: https://gerrit.ovirt.org/#/c/111177/26/roles/oVirt.manage-services/tasks/main.yml

"Set fact" should be "set_fact"

Version-Release number of selected component (if applicable):
ovirt-engine-4.4.3.7-0.22.el8ev.noarch
ovirt-engine-metrics-1.4.2-1.el8ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. # /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=manage-ovirt-metrics-services.yml or --playbook=cleanup-ovirt-metrics.yml
2.
3.

Actual results:
Fails

Expected results:
Succeeds

Additional info:

Comment 6 Guilherme Santos 2020-10-26 23:36:18 UTC

Verified on:
ovirt-engine-metrics-1.4.2.1-1.el8ev.noarch
ovirt-engine-4.4.3.8-0.1.el8ev.noarch

Steps:
1. # /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=manage-ovirt-metrics-services.yml
2. # /usr/share/ovirt-engine-metrics/setup/ansible/configure_ovirt_machines_for_metrics.sh --playbook=cleanup-ovirt-metrics.yml

Results:
playbooks running successfully as expected

Comment 10 errata-xmlrpc 2020-11-24 13:10:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5179