Bug 189009
| Summary: | Review Request: bzrtools - A collection of utilities and plugins for Bazaar-NG | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shahms E. King <shahms> |
| Component: | Package Review | Assignee: | Orion Poplawski <orion> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | steve.traylen |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-24 14:37:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Shahms E. King
2006-04-14 17:18:18 UTC
Looks like you want to update to 0.8.1, but: - spec file is clean and legible. - md5sum matches - rpmlint: E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644 E: bzrtools non-executable-script /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644 though since they are library routines, it isn't necessary to be executable. - license matches source. - owns all files and directories. MUST FIX: - add COPYING to %doc. Thanks for taking the time to review the package. I added COPYING, updated to 0.8.1 and fixed a minor problem with bzrtools requiring the same version of bzr rather than the actually required version of 0.8 The new files are at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-1.src.rpm (In reply to comment #1) > - rpmlint: > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/hunk_selector.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/__init__.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/diffstat.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf_tests.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/shelf.py 0644 > E: bzrtools non-executable-script > /usr/lib/python2.4/site-packages/bzrlib/plugins/bzrtools/test.py 0644 Oops, these need to get fixed. Those scripts that can be run directly need to be executable. Those that are library modules need to have #!/usr/bin/python stripped from them. More on Monday... Fixed, new files at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-2.src.rpm - Package builds in mock - rpmlint clean now Fix: - BR should be python, not python-devel. With that fix, this is approved. packages with BR: python are at: http://shahms.mesd.k12.or.us/packages/bzrtools.spec http://shahms.mesd.k12.or.us/packages/bzrtools-0.8.1-3.src.rpm APPROVED. Package Change Request ====================== Package Name: bzrtools New Branches: epel7 Owners: bar stevetraylen Git done (by process-git-requests). Dropped bar from the owners list. |