Bug 189013
| Summary: | Review Request: python-sqlalchemy - Modular and flexible ORM library for python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shahms E. King <shahms> |
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | metherid |
| Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-05-24 14:42:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Shahms E. King
2006-04-14 17:36:36 UTC
- rpmlint checks return: W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/content/tutorial.txt E: python-sqlalchemy wrong-script-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/testdocs.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/txt2myt.py Easily fixed with sed or perl. W: python-sqlalchemy doc-file-dependency /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py /usr/bin/env python will be installed, so this should be fine. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream Change source URL to download.sourceforge.net however, to automate downloads. - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - no need for .desktop file doc web server script thing doesn't work. $ ./runhtml.py : No such file or directory This is end of line problem as mentioned previously. Also, these scripts seem to convert and write html files, which fails due to permissions. You could generate this html in your %install phase, elminating the need for these scripts. Thanks for looking at the packages. Considering all of the rpmlint problems were related to the scripts for building the documentation (which is already built in the source tar ball), they are removed and not installed with the actual documentation. I also updated to the newest upstream version (0.1.7). http://shahms.mesd.k12.or.us/packages/python-sqlalchemy.spec http://shahms.mesd.k12.or.us/pacakges/python-sqlalchemy-0.1.7-1.src.rpm rpmlint and I are happy now. APPROVED Package Change Request ====================== Package Name: python-sqlalchemy New Branches: EL-5 Updated Fedora Owners: shahms,toshio,ivazqueznet Updated Fedora CC: Updated EPEL Owners: shahms,toshio,ivazqueznet Officially adding comaintainers and branching for EPEL-5 Package Change Request ====================== Package Name: python-sqlalchemy Updated EPEL Owners: shahms,toshio CVS done. Package Change Request ====================== Package Name: python-sqlalchemy New Branches: el6 Owners: sundaram pjp InitialCC: Git done (by process-git-requests). |