Bug 1890443

Summary: pyparted fails to build with Python 3.10: tests.test__ped_geometry.GeometryMapTestCase Aborted (core dumped)
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: pypartedAssignee: Dave Cantrell <dcantrell>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bcl, clumens, dcantrell, mhroncok, sbueno, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pyparted-3.11.7-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-23 19:57:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881    

Description Tomáš Hrnčiar 2020-10-22 08:49:17 UTC
pyparted fails to build with Python 3.10.0a1.

runTest (tests.test__ped_geometry.GeometryMapTestCase) ... make: *** [Makefile:42: test] Aborted (core dumped)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01715147-pyparted/

For all our attempts to build pyparted with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/pyparted/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Dave Cantrell 2020-10-23 12:19:32 UTC
  20: /lib64/libparted.so.2(ped_assert+0x45) [0x7f95b639fdc5]
  19: /lib64/libparted.so.2(ped_geometry_write+0x107) [0x7f95b63a64d7]
  18: /builddir/build/BUILD/pyparted-3.11.5/py3dir/build/lib.linux-x86_64-3.10/_ped.cpython-310-x86_64-linux-gnu.so(py_ped_geometry_write+0x8c) [0x7f95b6408b2c]
  17: /lib64/libpython3.10.so.1.0(+0x116d95) [0x7f95b6d66d95]
  16: /lib64/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x69e) [0x7f95b6d4928e]
  15: /lib64/libpython3.10.so.1.0(+0x1062c3) [0x7f95b6d562c3]
  14: /lib64/libpython3.10.so.1.0(+0x10eca0) [0x7f95b6d5eca0]
  13: /lib64/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x445) [0x7f95b6d49035]
  12: /lib64/libpython3.10.so.1.0(+0x1062c3) [0x7f95b6d562c3]
  11: /lib64/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x69e) [0x7f95b6d4928e]
  10: /lib64/libpython3.10.so.1.0(+0xf7c7c) [0x7f95b6d47c7c]
  9: /lib64/libpython3.10.so.1.0(_PyFunction_Vectorcall+0xe6) [0x7f95b6d56016]
  8: /lib64/libpython3.10.so.1.0(+0x10ee94) [0x7f95b6d5ee94]
  7: /lib64/libpython3.10.so.1.0(_PyEval_EvalFrameDefault+0x3306) [0x7f95b6d4bef6]
  6: /lib64/libpython3.10.so.1.0(+0xf7c7c) [0x7f95b6d47c7c]
  5: /lib64/libpython3.10.so.1.0(_PyFunction_Vectorcall+0xe6) [0x7f95b6d56016]
  4: /lib64/libpython3.10.so.1.0(_PyObject_FastCallDictTstate+0x63) [0x7f95b6d512d3]
  3: /lib64/libpython3.10.so.1.0(_PyObject_Call_Prepend+0x68) [0x7f95b6d5d768]
  2: /lib64/libpython3.10.so.1.0(+0x1ad07a) [0x7f95b6dfd07a]
  1: /lib64/libpython3.10.so.1.0(_PyObject_MakeTpCall+0x7f) [0x7f95b6d5180f]

That's what I can reproduce locally.  Working on it now.

Comment 2 Dave Cantrell 2020-10-23 12:28:14 UTC
@bcl Digging in to this, I'm getting 0 back from ped_device_sync().  Any thoughts?  I'm not sure why this is showing up now.  My first thought is sync(2) inside mock is to blame, but that's been working before.

Comment 3 Brian Lane 2020-10-23 19:02:12 UTC
This seems to fix it - https://github.com/dcantrell/pyparted/pull/77

Comment 4 Dave Cantrell 2020-10-23 19:15:06 UTC
Thanks for helping dig in to this.  I am glad it is on the Python side and not some larger underlying problem in libparted.  I've merged the change and will get a new release built in rawhide momentarily.

Comment 5 Dave Cantrell 2020-10-23 19:57:11 UTC
OK, pyparted-3.11.7 now builds in rawhide and with Python 3.10a in the copr test repo using mock.