Bug 1890683

Summary:	[RFE] smartly sync capsules with history tracking
Product:	Red Hat Satellite	Reporter:	Brad Buckingham <bbuckingham>
Component:	Capsule - Content	Assignee:	Samir Jha <sajha>
Status:	CLOSED ERRATA	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.8.0	CC:	ahumbe, dgross, dsynk, egolov, mmccune, pcreech, phess, sokeeffe, tpapaioa, wpinheir, zhunting
Target Milestone:	6.9.0	Keywords:	FutureFeature, Performance, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tfm-rubygem-katello-3.18.1-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	sat-smartsync (view as bug list)		Environment:
Last Closed:	2021-04-21 13:18:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Brad Buckingham 2020-10-22 17:40:06 UTC

Solution is such that:

We can store some data: 
smart_proxy_id 
repository_id
started
finished

*As part of any capsule sync for a given repo*: SYNC_HISTORY At the start of the sync for a given repo and smart proxy, any entry in the data would be deleted A new entry would be created with the current start time At the end of the sync, the finished time would be filled in, if the data still exists (hasn't been deleted by another task) This functions as a 'two-stage' ACK of having synced successfully

*As part of CV promotion* if changes are detected for a given repo during CV promotion, delete any entries for those repos in the SYNC_HISTORY table

*as part of repository update* if a repository is updated, unprotected changed or download_policy changed (for inherited proxies), delete all history items for any instance of that repository

*as part of content upload into a repo*, any history events for that repo are deleted.

*if upstream_name for docker repos is changed*, delete all history items for that particular repostiory

*at repo sync time in Library* if there are changes (or package upload/remove), we need to delete all hsitory items for that particular repository

*At capsule sync time*, if a history event exists in the table for a given repo and smart proxy that 'finished', do not schedule the sync.
*
A full capsule sync* will delete all history events for that capsule

Comment 1 Brad Buckingham 2020-10-22 17:40:10 UTC

Created from redmine issue https://projects.theforeman.org/issues/30824

Comment 2 Brad Buckingham 2020-10-22 17:40:11 UTC

Upstream bug assigned to None

Comment 3 Bryan Kearney 2020-11-06 20:02:12 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/30824 has been resolved.

Comment 5 Tasos Papaioannou 2021-01-15 21:09:42 UTC

Verified on 6.9.0 snap 9.0.

1.) Add a Capsule to a lifecycle environment.
2.) Sync a new repo and add it to a content view.
3.) Publish and promote the content view to the lifecycle environment.
4.) Sync the Capsule.
5.) Check that a history record exists on the Satellite:

# foreman-rake console
irb(main):001:0> ::Katello::SmartProxySyncHistory.count 
=> 1

irb(main):003:0> ::Katello::SmartProxySyncHistory.all
=> #<ActiveRecord::Relation [#<Katello::SmartProxySyncHistory id: 3, smart_proxy_id: 2, repository_id: 7, started_at: "2021-01-15 18:57:35", finished_at: "2021-01-15 18:58:23">]>

6.) Sync the Capsule again, with the 'Optimized Sync' option.
7.) Verify that the history is the same:

irb(main):004:0> ::Katello::SmartProxySyncHistory.all
=> #<ActiveRecord::Relation [#<Katello::SmartProxySyncHistory id: 3, smart_proxy_id: 2, repository_id: 7, started_at: "2021-01-15 18:57:35", finished_at: "2021-01-15 18:58:23">]>

8.) Sync the Capsule again, with the 'Complete Sync' option.
9.) Verify that a new history record is now present for the repo and capsule:

irb(main):009:0> ::Katello::SmartProxySyncHistory.all
=> #<ActiveRecord::Relation [#<Katello::SmartProxySyncHistory id: 4, smart_proxy_id: 2, repository_id: 7, started_at: "2021-01-15 19:45:38", finished_at: "2021-01-15 19:48:03">]>

Comment 8 errata-xmlrpc 2021-04-21 13:18:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.9 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1313