Bug 1891154

Summary: laszip-devel should be a dependancy of PDAL-devel
Product: [Fedora] Fedora Reporter: Nyall Dawson <nyall.dawson>
Component: PDALAssignee: markusN <neteler>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 33CC: manisandro, neteler
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: PDAL-2.2.0-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-13 03:46:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nyall Dawson 2020-10-23 22:56:12 UTC
Description of problem:

After install PDAL-devel I'm unable to build software which uses the pdal library without first also installing the laszip-devel package.

The following error is obtained if the laszip-devel package is not installed:

/usr/include/pdal/io/LasReader.hpp:44:10: fatal error: laszip/laszip_api.h: No such file or directory
   44 | #include <laszip/laszip_api.h>
      |          ^~~~~~~~~~~~~~~~~~~~~

Comment 1 markusN 2020-10-24 12:17:58 UTC
I have added the desired dependency but PDAL refuses to properly build:

neteler's PDAL-2.2.0-2.fc34 failed to build
	http://koji.fedoraproject.org/koji/buildinfo?buildID=1633912

neteler's PDAL-2.2.0-2.fc33 failed to build
	http://koji.fedoraproject.org/koji/buildinfo?buildID=1633918

It is really weird:

```
 31/113 Test  #35: pdal_io_faux_test ......................Child aborted***Exception:   0.26 sec

...

[ RUN      ] BpfTestZlib.roundtrip_byte_compression
[       OK ] BpfTestZlib.roundtrip_byte_compression (12 ms)
[ RUN      ] BpfTestZlib.roundtrip_dimension_compression
/builddir/build/BUILD/PDAL-2.2.0-src/test/unit/io/BpfSupport.hpp:112: Failure
Expected equality of these values:
  x
    Which is: 493994.88
  pts2[i].x
    Which is: 494057.31
/builddir/build/BUILD/PDAL-2.2.0-src/test/unit/io/BpfSupport.hpp:113: Failure
Expected equality of these values:
  y
    Which is: 4877429.5
  pts2[i].y
    Which is: 4877433.5
/builddir/build/BUILD/PDAL-2.2.0-src/test/unit/io/BpfSupport.hpp:114: Failure
Expected equality of these values:
  z
    Which is: 123.93
  pts2[i].z
    Which is: 130.63

...
/builddir/build/BUILD/PDAL-2.2.0-src/test/unit/io/BpfSupport.hpp:179: Failure
Expected equality of these values:
  z
    Which is: 123.93
  d.z
    Which is: 127.42999
[  FAILED  ] BpfTestZlib.roundtrip_dimension_compression (1716 ms)
[ RUN      ] BpfTestZlib.roundtrip_point_compression
[       OK ] BpfTestZlib.roundtrip_point_compression (21 ms)
[----------] 6 tests from BpfTestZlib (1773 ms total)
[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (1773 ms total)
[  PASSED  ] 5 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] BpfTestZlib.roundtrip_dimension_compression
 1 FAILED TEST

...

98% tests passed, 2 tests failed out of 113
Total Test time (real) =  10.97 sec
The following tests FAILED:
	 31 - pdal_io_bpf_zlib_test (Failed)
	 35 - pdal_io_faux_test (Child aborted)
Errors while running CTest
error: Bad exit status from /var/tmp/rpm-tmp.Gs0BsI (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.Gs0BsI (%check)
```


And:

```
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from OverlayFilterTest
[ RUN      ] OverlayFilterTest.nostream
unknown file: Failure
C++ exception with description "Unable to open stream for '/builddir/build/BUILD/PDAL-2.2.0-src/test/data/../temp/out.las' with error 'No such file or directory'" thrown in the test body.
[  FAILED  ] OverlayFilterTest.nostream (72 ms)
[ RUN      ] OverlayFilterTest.stream
[       OK ] OverlayFilterTest.stream (119 ms)
[----------] 2 tests from OverlayFilterTest (191 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (191 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OverlayFilterTest.nostream
 1 FAILED TEST


...

[       OK ] LasWriterTest.all_extra_dims (18 ms)
[ RUN      ] LasWriterTest.forward
(readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs not found
(readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs not found
[       OK ] LasWriterTest.forward (741 ms)
[ RUN      ] LasWriterTest.forwardvlr
proj_uom_get_info_from_database: unit of measure not found
[       OK ] LasWriterTest.forwardvlr (35 ms)
[ RUN      ] LasWriterTest.flex
[       OK ] LasWriterTest.flex (5 ms)
[ RUN      ] LasWriterTest.flex2
[       OK ] LasWriterTest.flex2 (3 ms)
[ RUN      ] LasWriterTest.laszip
unknown file: Failure
C++ exception with description "readers.las: reading point 562 of 110000 total points" thrown in the test body.
[  FAILED  ] LasWriterTest.laszip (164 ms)
[ RUN      ] LasWriterTest.laszip1_4
unknown file: Failure
C++ exception with description "Unable to open stream for '/builddir/build/BUILD/PDAL-2.2.0-src/test/data/../temp/temp.laz' with error 'No such file or directory'" thrown in the test body.
[  FAILED  ] LasWriterTest.laszip1_4 (166 ms)
[ RUN      ] LasWriterTest.flex_vlr
[       OK ] LasWriterTest.flex_vlr (9 ms)

...

[       OK ] LasWriterTest.issue2320 (9 ms)
[ RUN      ] LasWriterTest.synthetic_points
[       OK ] LasWriterTest.synthetic_points (1 ms)
[----------] 27 tests from LasWriterTest (1842 ms total)
[----------] Global test environment tear-down
[==========] 27 tests from 1 test suite ran. (1842 ms total)
[  PASSED  ] 25 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] LasWriterTest.laszip
[  FAILED  ] LasWriterTest.laszip1_4
 2 FAILED TESTS
108/113 Test #100: pdal_app_test ..........................   Passed    1.64 sec
109/113 Test  #34: pdal_io_ept_addon_writer_test ..........   Passed    3.50 sec
110/113 Test  #84: pdal_filters_pmf_test ..................   Passed    3.33 sec
111/113 Test #109: translate_test .........................   Passed    4.25 sec
112/113 Test  #33: pdal_io_ept_reader_test ................   Passed    5.43 sec
113/113 Test  #58: pdal_filters_colorization_test .........   Passed    6.63 sec
96% tests passed, 4 tests failed out of 113
Total Test time (real) =   6.81 sec
The following tests FAILED:
	 31 - pdal_io_bpf_zlib_test (Child aborted)
	 35 - pdal_io_faux_test (Child aborted)
	 39 - pdal_io_las_writer_test (Failed)
	 82 - pdal_filters_overlay_test (Failed)
Errors while running CTest
error: Bad exit status from /var/tmp/rpm-tmp.ikWes8 (%check)
    Bad exit status from /var/tmp/rpm-tmp.ikWes8 (%check)
```

I have no clue why PDAL no longer compiles.

Anything wrong in the SPEC file:
https://src.fedoraproject.org/rpms/PDAL/blob/master/f/PDAL.spec
?

Comment 2 Fedora Update System 2020-11-04 17:55:23 UTC
FEDORA-2020-3750b71c79 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-3750b71c79

Comment 3 Fedora Update System 2020-11-05 03:28:21 UTC
FEDORA-2020-3750b71c79 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-3750b71c79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-3750b71c79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2020-11-13 03:46:55 UTC
FEDORA-2020-3750b71c79 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.