Bug 1891416

Summary: xml validate should fail when config 'ramfb' video with pci or dimm address
Product: Red Hat Enterprise Linux Advanced Virtualization Reporter: Lili Zhu <lizhu>
Component: libvirtAssignee: khanicov
Status: CLOSED ERRATA QA Contact: Lili Zhu <lizhu>
Severity: low Docs Contact:
Priority: low    
Version: 8.4CC: chhu, jdenemar, jsuchane, jtomko, khanicov, lmen, mprivozn, virt-maint, xuzhang, yafu
Target Milestone: rcKeywords: Triaged, Upstream
Target Release: 8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-7.3.0-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-16 07:51:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 7.2.0
Embargoed:

Description Lili Zhu 2020-10-26 08:11:09 UTC 
Description of problem:
xml validate should fail when config 'ramfb' video with pci or dimm address

Version-Release number of selected component (if applicable):
libvirt-daemon-6.6.0-7.module+el8.3.0+8424+5ea525c5.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare a guest xml containing 'ramfb' video with pci or dimm address
# cat avocado-vt-vm1.xml 
...
   <video>
    <model type='ramfb' heads='1' primary='yes'/>
      <address type='dimm' slot='1'/>
    </video>
...

or 
...
  <video>
    <model type='ramfb' heads='1' primary='yes'/>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/>
  </video>
...


2. try to validate the guest xml
# virt-xml-validate avocado-vt-vm1.xml 
avocado-vt-vm1.xml validates


Expected results:
validate the above guest xml should fail, since address' is not supported for 'ramfb' video devices

Additional info:
Comment 1 khanicov 2021-03-05 12:04:00 UTC 
Patch proposed on the list:
https://listman.redhat.com/archives/libvir-list/2021-March/msg00289.html
Comment 2 khanicov 2021-03-11 10:44:07 UTC 
Merged upstream as:

f11f32326f XML validate that 'ramfb' has no address

v7.1.0-169-gf11f32326f
Comment 3 Michal Privoznik 2021-03-11 10:45:36 UTC 
Moving to POST per comment 2.
Comment 7 Lili Zhu 2021-05-30 09:01:20 UTC 
Verify this bug with:
libvirt-7.3.0-1.module+el8.5.0+11004+f4810536.x86_64

As the testing result matches with the expected result in discription,
mark the bug as verified.
Comment 9 errata-xmlrpc 2021-11-16 07:51:01 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:av bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4684