Bug 1891552

Summary:	Handle missing labels as empty.
Product:	OpenShift Container Platform	Reporter:	German Parente <gparente>
Component:	Monitoring	Assignee:	Andrew Pickering <anpicker>
Status:	CLOSED ERRATA	QA Contact:	hongyan li <hongyli>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.5	CC:	alegrand, anpicker, aos-bugs, erooth, hongyli, juzhao, kakkoyun, lcosic, nmukherj, pkrupa, surbania
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1891697 (view as bug list)		Environment:
Last Closed:	2021-02-24 15:28:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1891697

Description German Parente 2020-10-26 15:40:32 UTC

Description of problem:

it seems openshift console is evaluating empty labels in silences in a different way than alertmanager/prometheus console.

There's a pull request upstream to fix this:

https://github.com/openshift/console/pull/6940
Handle missing labels as empty


Version-Release number of selected component (if applicable): 4.5

This pull request has already been merged and I am reporting this bug to have it included downstream.

Comment 1 Andrew Pickering 2020-10-27 00:16:04 UTC

Fix was merged for 4.7. The task here is to backport to 4.6 and 4.5.

Comment 2 Junqi Zhao 2020-10-27 03:38:07 UTC

(In reply to Andrew Pickering from comment #1)
> Fix was merged for 4.7. The task here is to backport to 4.6 and 4.5.

what is the Target Release for this bug, no value is set

Comment 3 Andrew Pickering 2020-10-27 05:58:13 UTC

(In reply to Junqi Zhao from comment #2)
> what is the Target Release for this bug, no value is set

I've now converted this to target 4.7.0 and created https://bugzilla.redhat.com/show_bug.cgi?id=1891697 for the 4.6.z backport.

Comment 5 hongyan li 2020-11-09 08:56:39 UTC

Issue is fixed in payload 4.7.0-0.nightly-2020-10-27-051128

The console and AlertManager handle silences same way now.
I only created one silence with a valid label and an empty label value, for example: nonexistinglabel="", enable Regx.
 
The alert is silenced on both AlertManager and console.

Comment 9 errata-xmlrpc 2021-02-24 15:28:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633