Bug 1891820

Description of problem:

In OCP 4.5, the max surge value can be specified by editing the update strategy. By default, the value for Max surge is 25%. The values of both max-surge and max-unavailable can't be set to zero.

If we specify the max surge value as "zero" in the update strategy then after saving the changes, it shows 1 greater than <pod count>. It should not accept the value "zero" either or it should give us the error.

This is happening only when we set the Max-surge value as zero. For other max surge values like 1, 2, 3 it is working fine.

When we select both max surge and max unavailable as zero, it gives us the error which is expected.

Version-Release number of selected component (if applicable):

OCP 4.5 Web-console


Steps to Reproduce:
1. Create one sample project. Deploy Httpd app inside this project.

2. In the OpenShift web-console, go to Workload -> Deployments. You should see the replicas of the pod.

3. Go to action -> Select edit update strategy. 

4. Specify the max surge value as "Zero" and save the changes.

5. Now check for the max surge value. It should show "1 greater than <pod count>".

6. Again go to edit update strategy. Keep max surge value as "zero" only and again save the changes. 

7. Now the max surge count will show the value as "25% greater than <pod count>"

Actual results:

Max surge value is showing two different values when we set max surge to zero.

Expected results:

When we set the max surge value to zero the max surge value should be shown correctly.


Additional info:

Incorrect values are shown when we set the max surge value as zero only. The max surge shows correct values when we set max surge value to 1, 2 or 3.