Bug 1891892

Summary: The windows oc.exe binary does not have version metadata
Product: OpenShift Container Platform Reporter: OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component: ocAssignee: Maciej Szulik <maszulik>
Status: CLOSED ERRATA QA Contact: zhou ying <yinzhou>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: aos-bugs, jokerman, mfojtik, yselkowi
Target Milestone: ---Keywords: UpcomingSprint
Target Release: 4.6.z   
Hardware: x86_64   
OS: Windows   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Metadata providing version information were not produced during build process. Consequence: No version information was present on windows binaries. Fix: Generate proper windows version information to be consumed during build process by the go compiler. Result: Version information is available on windows binaries.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-08 13:50:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1891555    
Bug Blocks: 1922585    
Attachments:
Description Flags
oc detail
none
detail none

Description OpenShift BugZilla Robot 2020-10-27 15:40:42 UTC 
+++ This bug was initially created as a clone of Bug #1891555 +++

Created attachment 1724192 [details]
screenshot of the lack of version info on the oc.exe windows binary

Description of problem:
The oc.exe tool for windows does not have version meta-data imbeded in it. This makes automated deployment/management of it very difficult in an enterprise setting.

Version-Release number of selected component (if applicable):

4.4.23

How reproducible:

Every time

Steps to Reproduce:
1. Download windows tools
2. install
3. right click on oc.exe, look in the details tab

Actual results:

file and product version information is blank (see attached screenshot)

Expected results:

file and product version to be populated with data that can be used to Windows software deployment tooling.

Additional info:

--- Additional comment from yselkowi on 2020-10-26 16:20:17 UTC ---

That's what goversioninfo is supposed to be for.  It seems the build infrastructure in origin used to handle that, specifically:

https://github.com/openshift/origin/blob/master/hack/lib/constants.sh#L198-L259
https://github.com/openshift/origin/blob/master/hack/lib/build/binaries.sh#L218-L221
https://github.com/openshift/origin/blob/master/hack/lib/build/binaries.sh#L238-L240

This appears not have been moved over to the separate oc repo when it was split out.
Comment 1 Maciej Szulik 2020-11-13 10:55:27 UTC 
This is waiting in the queue for its turn.
Comment 2 Maciej Szulik 2020-12-04 16:20:33 UTC 
PR in the queue.
Comment 3 Maciej Szulik 2021-01-15 11:49:29 UTC 
PR in the queue.
Comment 4 zhou ying 2021-01-25 02:05:44 UTC 
Build the oc with the PR , could see the file and product version to be populated with SOURCE_GIT_TAG=4.6.99.
Comment 5 zhou ying 2021-01-25 06:44:49 UTC 
Created attachment 1750399 [details]
oc detail
Comment 7 zhou ying 2021-02-01 05:14:46 UTC 
Created attachment 1752757 [details]
detail
Comment 8 zhou ying 2021-02-01 05:16:35 UTC 
Download the oc from payload: https://openshift-release-artifacts.apps.ci.l2s4.p1.openshiftapps.com/4.6.0-0.nightly-2021-01-30-211400/, could see the oc version like https://bugzilla.redhat.com/show_bug.cgi?id=1891892#c7. will move to verified status.
Comment 11 errata-xmlrpc 2021-02-08 13:50:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.6.16 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0308