Bug 189219

Summary:	Review Request: poker-eval - Poker hand evaluator library
Product:	[Fedora] Fedora	Reporter:	Christopher Stone <tkmame>
Component:	Package Review	Assignee:	Wart <wart>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-23 06:12:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Christopher Stone 2006-04-18 14:00:59 UTC

Spec URL: http://tkmame.retrogames.com/fedora-extras/poker-eval.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/poker-eval-130.0-2.src.rpm

** NOTE ** You may have to download src.rpm directly from:
http://tkmame.retrogames.com/fedora-extras/

Description:

This package is a free (GPL) toolkit for writing programs which
simulate or analyze poker games.

Comment 1 Wart 2006-04-22 06:26:13 UTC

rpmlint output clean.

MUST
====
* Spec file named appropriately
* Source matches upstream
  b6feea367ba1c49d85fb04cf5913e2d9  poker-eval-130.0.tar.gz
* Spec file legible and in Am. English
* No BR: needed
* No locales
* ldconfig called correctly for .so files
* GPL license ok, license file included
* %{buildroot} cleaned appropriately
* macro usage consistent
* contains code, not content
* headers and pkgconfig files in -devel
* un-suffixed library in -devel
* -devel requires base
* No .desktop file needed
* Builds clean in mock on:
  FC-4 i386, FC4-x86_64, FC-5 i386, FC-5 x86_64

SHOULD
======
* You might want to let upstream know about the empty directory named '*'
  in the source tarball.
* You might want to suggest to upstream to include the GPL reference at the top
of the various .c and .h files.
* The C examples would make more sense in an examples/ subdirectory instead of
the top level doc dir.

APPROVED

Comment 2 Christopher Stone 2006-04-23 06:12:39 UTC

- Empty dir '*' in tarball was caused by a bug in automake which has been worked
around in CVS and the directory will be gone in the poker-eval-131 version.
- GPL references have been fixed and will show up in the poker-eval-131 version.
- Spec file has been fixed so that the .c files in devel's %doc are now
contained in a samples/ folder and this will be in release 3 rpm of
poker-eval-130 version.

Comment 3 Hans de Goede 2006-05-06 07:24:26 UTC

Modifying the Summary, because it seems that:
http://fedoraproject.org/wiki/Extras/PackageStatus

Gets confused by the [Games SIG]