Bug 1892403
Summary: | Image download via SDK broken with older engines | ||
---|---|---|---|
Product: | [oVirt] vdsm | Reporter: | Nir Soffer <nsoffer> |
Component: | Core | Assignee: | Nir Soffer <nsoffer> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Ilan Zuckerman <izuckerm> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.40.35 | CC: | aefrat, aoconnor, bugs, sfishbai, tnisan |
Target Milestone: | ovirt-4.4.4 | Keywords: | Regression |
Target Release: | 4.40.40 | Flags: | pm-rhel:
ovirt-4.4+
aoconnor: blocker- |
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | vdsm-4.40.40 | Doc Type: | Bug Fix |
Doc Text: |
Cause:
Incorrect handling of missing argument when vdsm is accessed by older engines (engine < 4.4.3).
Consequence:
Downloading a disk with snapshots using NBD return incorrect data only from the top snapshot.
Fix:
Vdsm handles missing argument properly when using older engine versions.
Result:
Download of disks with snapshots return data from all snapshots as expected.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2021-01-12 16:23:51 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nir Soffer
2020-10-28 16:58:16 UTC
This is a regression introduced by fix for bug 1847090. This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Tested with engine 4.4.3.2. Without this fix (vdsm 4.40.35.1) $ ./download_disk.py -c engine3 8f2ce956-47f3-49d7-ae68-bcf810addee5 download.qcow2 [ 0.0 ] Connecting... [ 0.3 ] Creating image transfer... [ 1.8 ] Transfer ID: b5f93f9d-13f1-4823-80ed-9534e7da278c [ 1.8 ] Transfer host name: host3 [ 1.8 ] Downloading image... [ 100.00% ] 6.00 GiB, 0.13 seconds, 46.24 GiB/s [ 1.9 ] Finalizing image transfer... $ qemu-img info download.qcow2 image: download.qcow2 file format: qcow2 virtual size: 6 GiB (6442450944 bytes) disk size: 196 KiB cluster_size: 65536 Format specific information: compat: 1.1 compression type: zlib lazy refcounts: false refcount bits: 16 corrupt: false With the fix: $ ./download_disk.py -c engine3 8f2ce956-47f3-49d7-ae68-bcf810addee5 download.qcow2 [ 0.0 ] Connecting... [ 0.1 ] Creating image transfer... [ 1.4 ] Transfer ID: 568f95e1-bff7-42c2-84ff-b3ae474a42d3 [ 1.4 ] Transfer host name: host3 [ 1.4 ] Downloading image... [ 100.00% ] 6.00 GiB, 12.83 seconds, 478.81 MiB/s [ 14.2 ] Finalizing image transfer... $ qemu-img info download.qcow2 image: download.qcow2 file format: qcow2 virtual size: 6 GiB (6442450944 bytes) disk size: 2.51 GiB cluster_size: 65536 Format specific information: compat: 1.1 compression type: zlib lazy refcounts: false refcount bits: 16 corrupt: false Tested on: rhv-release-4.4.3-7-001.noarch ovirt-engine-4.4.3.12-0.1.el8ev.noarch vdsm-4.40.35.1-1.el8ev.x86_64 This setup complies to the requirement from description: "1. Use engine < 4.4.3.7 with newer vdsm >= 4.40.32" Steps: 1. Use engine < 4.4.3.7 with newer vdsm >= 4.40.32 2. Create VM with one disk with some data 3. Stop the VM 4. Create a snapshot including the disk 5. Download the disk using download_disk.py [root@storage-ge10-vdsm1 examples]# python3 download_disk.py 5bc1c7c6-c6b5-4936-8893-f400fe4993c7 /tmp/downloaded -c engine [ 0.0 ] Connecting... [ 0.2 ] Creating image transfer... [ 2.9 ] Transfer ID: 4dc9e7e7-6a0f-4f1c-ba8f-b76731696e41 [ 2.9 ] Transfer host name: host_mixed_1 [ 2.9 ] Downloading image... [ 100.00% ] 10.00 GiB, 11.81 seconds, 866.90 MiB/s [ 14.7 ] Finalizing image transfer... Expected: The download includes the entire disk. Not just the snapshot. Actual result: As expected [root@storage-ge10-vdsm1 examples]# qemu-img info /tmp/downloaded image: /tmp/downloaded file format: qcow2 virtual size: 10 GiB (10737418240 bytes) disk size: 2.3 GiB cluster_size: 65536 Format specific information: compat: 1.1 compression type: zlib lazy refcounts: false refcount bits: 16 corrupt: false This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days |