Bug 1892558

Proposal: https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/thread/53MEMVASHK6YH5ED5RTO5NMEIEOM4LVP/

Tested on RHEL-8.5.0-20210524.d.0+kexec-tools-2.0.20-49.el8 on all arch, the return values are the same as the expect values,all of them passed.

Components:
RHEL-8.5.0-20210524.d.0
kernel-4.18.0-305.7.el8.kpq1
kexec-tools-2.0.20-49.el8
crash-7.3.0-2.el8

test steps:
# rpm -q kexec-tools
kexec-tools-2.0.20-49.el8.ppc64le
# . /usr/lib/kdump/kdump-lib.sh
# kdump_get_arch_recommend_size    <== it will return the value.
        

1. x86_64 - total memory is 32G
a. crashkernel=auto,the return value is 192M  -- PASS
b. crashkernel=256M,the return value is 192M  -- PASS
c. mem=800M,the return value is 0M            -- PASS

2. aarch64 - total memory is 5575M
a. crashkernel=auto,the return value is 448M  -- PASS
b. crashkernel=256M,the return value is 448M  -- PASS
c. mem=1024M,the return value is 0M           -- PASS

3. s390x - total memory is 8G
a. crashkernel=auto,the return value is 192M  -- PASS
b. crashkernel=256M,the return value is 192M  -- PASS
c. mem=900M,the return value is 0M            -- PASS

4. ppc64le - kdump - total memory is 32G
a. crashkernel=auto,the return value is 1G    -- PASS
b. crashkernel=256M,the return value is 1G    -- PASS
c. mem=1024M,the return value is 0M           -- PASS

5. ppc64le - kdump - total memory is 32G
a. crashkernel=auto,the return value is 1G    -- PASS
b. crashkernel=256M,the return value is 1G    -- PASS
c. mem=4096M,the return value is 768M         -- PASS
d. mem=2048M,the return value is 0M           -- PASS

beaker job:
https://beaker.engineering.redhat.com/jobs/5406150 (x86_64/aarch64/s390x)
https://beaker.engineering.redhat.com/jobs/5406687 (ppc64le - kdump)
https://beaker.engineering.redhat.com/jobs/5406639 (ppc64le - fadump)

comment#9 is tested against an official build https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1612548

But I made another rapid successive building at that day, and finally pick up kexec-tools-2.0.20-50.el8 into errata.

The difference between the two releases is minor as the following commits
b2dccde2 Release-2.0.20-50
2c2ae3b9 rd.route should use the name from kdump_setup_ifname
f97d3cac get kdump ifname once in kdump_install_netdev
a3ef9148 Release-2.0.20-49
11608030 kdump-lib.sh: fix the case if no enough total RAM for kdump  in get_recommend_size()
557a2c2f Release-2.0.20-48


2c2ae3b9 rd.route should use the name from kdump_setup_ifname and f97d3cac get kdump ifname once in kdump_install_netdev
only touch dracut-module-setup.sh, not kdump-lib.sh.

As comment#9, I can not pick up kexec-tools-2.0.20-49 in errata, which will deprecate kexec-tools-2.0.20-50.

But I think that changing the fix version from kexec-tools-2.0.20-49 to -50 is safe.

I will be more careful to correct the fix version in time, which is automatically filled by gating engine now.

Thanks

Hi Hanns,

Based on QE tests, the . /usr/lib/kdump/kdump-lib.sh works as expected (comment-6).
Can I know what failed IBM tests ? (Verified: FailedQA Tested)

Thanks,
Emma

(In reply to Emma Wu from comment #12)
> Hi Hanns,
> 
> Based on QE tests, the . /usr/lib/kdump/kdump-lib.sh works as expected
> (comment-6).
> Can I know what failed IBM tests ? (Verified: FailedQA Tested)
> 
> Thanks,
> Emma
.
Hello Gustavo,
please check with the IBM team about the status of this bugzilla ...
Thanks in advance for your support.

------- Comment From hbathini.com 2021-06-24 02:12 EDT-------
kdumpctl estimate works as intended except for the below warning
when KDUMP_KERNELVER is set in /etc/sysconfig/kdump file:

/lib/kdump/kdump-lib.sh: line 692: [: missing `]'

The patch to fix it is already posted at:

https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/thread/T37P3VL6B2RZ7JFWN6NA6L4NA4XRC56W/
("[PATCH] kdump-lib.sh: fix a warning in prepare_kdump_bootinfo()")

------- Comment From hbathini.com 2021-06-24 02:13 EDT-------
Verification successful

(In reply to IBM Bug Proxy from comment #14)
> ------- Comment From hbathini.com 2021-06-24 02:12 EDT-------
> kdumpctl estimate works as intended except for the below warning
> when KDUMP_KERNELVER is set in /etc/sysconfig/kdump file:
> 
> /lib/kdump/kdump-lib.sh: line 692: [: missing `]'
> 
> The patch to fix it is already posted at:
> 
> https://lists.fedoraproject.org/archives/list/kexec@lists.fedoraproject.org/
> thread/T37P3VL6B2RZ7JFWN6NA6L4NA4XRC56W/

This issue was tracked in bug 1966881- RHEL8.4 - kdump service restart throws a bash script error when KDUMP_KERNELVER is set .

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: kexec-tools security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4404