Bug 189301

Created attachment 128067 [details]
x86_64 build warnings

I get a number of potentially problematic build warnings on x86_64 like this:
src/mixer.c:84: warning: cast from pointer to integer of different size

These occur in the following files:
src/mixer.c
src/surface.c
src/time.c

Spec URL: http://tkmame.retrogames.com/fedora-extras/pygame.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/pygame-1.7.1-2.src.rpm

** NOTE ** You may have to download the src.rpm from
http://tkmame.retrogames.com/fedora-extras/

%changelog
* Thu Apr 20 2006 Christopher Stone <chris.stone> 1.7.1-2
- Added a patch to clean up some warnings on 64 bit compiles

rpmlint output clean.

MUST
====
* Package and spec file named appropriately
* Source matches upstream
  05d86d1af446f79411359400951053b7  pygame-1.7.1release.tar.gz
* LGPL license ok.  License file included
* Spec file legible and in Am. English
* Compiles and builds in mock on:
  FC-4 i386, FC-4 x86_64, FC-5 i386, FC-5 x86_64
* No offensive BR:
* No locales
* No .so's needed in the linker's path
* Not relocatable
* Owns directories that it creates
* No duplicate %files
* %{buildroot} cleaned in %clean and at start of %install
* Macro usage consistent
* headers placed in -devel package
* -devel requires base
* No .la files
* No .desktop file needed

MUSTFIX
=======
* python-abi isn't needed on FC-4 and later:
  http://fedoraproject.org/wiki/Packaging/Python

Please remove the Requires: on python-abi after importing.

APPROVED

Obsoletes: python-pygame < 1.7.1
Provides: python-pygame = %{version}-%{release}

The above would be appreciated in order to achieve clean upgrades from the same
(orphaned) package in livna.org.

The two '='s in the -devel dependency look suspicious:
Requires: %{name} == %{version}-%{release}

Fixed as release 3.  Perhaps someone on livna could make a pygame-nonfree rpm or
something?  I did not know this rpm even existed! :o)

What was in the livna package that made it non-free?  Perhaps it had a
dependency on smpeg, mp3, or something like that?

The full package requires smpeg-devel to create a movie.so file.  I think that
is the only extra file that is missing.  The -devel package I build includes an
ffmovie.h file, but I think this is okay to include.  Let me know otherwise.

From what I can tell, the ffmovie.{c|h} files are only wrappers that call into
the ffmpeg library to do the actual decoding work.  I don't believe this is a
problem, especially since movie.so doesn't get build, resulting in no dependency
on mpeg libraries.

ffmovie.h is not too useful in this -devel package though because it contains
"#include <ffmpeg/avformat.h>".

By the way, -devel is missing these (see #include's in installed headers):
Requires: python-devel
Requires: SDL_ttf-devel
Requires: SDL_mixer-devel

Fixed in release 4.  Thanks.

Package Change Request
======================
Package Name: pygame
Updated Fedora Owners: xulchris rnorwood

You don't have to make a CVS request to change ownership; the new owner just needs to drop by the pkgdb and click "Add myself to this package", and the existing owner can accept.  When Fedora comes back up, of course.

cvs done.

Package Change Request
======================
Package Name: pygame
New Branches: EL-6
Owners: pbrobinson sdz

There is already a EL-6 branch. You should be able to add yourself in pkgdb