Bug 1893035

Summary:	rhv-log-collector-analyzer: check for double quotes in IPTablesConfigSiteCustom
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Germano Veit Michel <gveitmic>
Component:	rhv-log-collector-analyzer	Assignee:	Germano Veit Michel <gveitmic>
Status:	CLOSED ERRATA	QA Contact:	Guilherme Santos <gdeolive>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.2	CC:	dfodor, gdeolive, mavital, michal.skrivanek
Target Milestone:	ovirt-4.4.4	Keywords:	FieldEngineering, ZStream
Target Release:	4.4.4
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	rhv-log-collector-analyzer-1.0.6-1.el8ev	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-02 13:57:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Germano Veit Michel 2020-10-30 00:02:03 UTC

Description of problem:

Host ansible installation fails without clear message if the cluster is still set to iptables and engine-config
key IPTablesConfigSiteCustom contains double quotes. Please make rhv-log-collector-analyzer detect this and warn the user about it.

See email thread "quotes in IPTablesConfigSiteCustom (was: problems installing standard Linux as nodes in 4.4)"

Additional info:
https://access.redhat.com/solutions/5521361

Comment 3 Guilherme Santos 2021-01-06 16:44:41 UTC

Verified on:
rhv-log-collector-analyzer-1.0.6-1.el8ev.noarch
ovirt-engine-4.4.4.5-0.10.el8ev.noarch

Steps:
1. # engine-config -s IPTablesConfigSiteCustom='-A INPUT -p tcp --dport 12345 -m comment --comment "Some comment here" -j ACCEPT version: general
2. # rhv-log-collector-analyzer

Results:
rhv-log-collector-analyzer detects double quote and complains:
```
Double quotes in iptables configuration can make host installation or upgrade fail during ansible install

b’IPTablesConfigSiteCustom'
b'"-A INPUT -p tcp --dport 12345 -m comment --comment ""Some comment here"" -j ACCEPT version: general"'
```

Comment 7 errata-xmlrpc 2021-02-02 13:57:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: RHV-M(ovirt-engine) 4.4.z security, bug fix, enhancement update [ovirt-4.4.4]), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0381

Comment 8 meital avital 2022-08-10 22:04:36 UTC

Due to QE capacity, we are not going to cover this issue in our automation