Bug 1893457

Any thoughts on whether something similar as what OpenSUSE does could be done in Fedora?

Hello? Is anybody still maintaining this package?

Currently waiting on the upstream merge request to be approved.

> Currently waiting on the upstream merge request to be approved.

It can take some time (the issue is known for 2 years for now). Meanwhile it's better to apply the patch or disable Ogg support, because currently EasyTag is not Ogg tagger but Ogg destroyer.

The way I stumbled upon this bug was that I, being unaware of this long-standing issue with easytag, used it to tag some ogg files for which I had no backups, thus destroying them. I would hate for that to happen to someone else, and thus I think it would be good to apply a patch downstream, or disable ogg support altogether, while waiting for upstream to fix the issue on their end. That is, unless there is a Fedora policy forbidding that.

The way things are going, it looks like easytag may be almost unmaintained, with the bug having been open for several years, and the merge request [1] sitting untouched for several months, with who knows how many more months until they manage to actually merge the fix. That is a lot of time for people to accidentally destroy their ogg files.


[1] https://gitlab.gnome.org/GNOME/easytag/-/merge_requests/8

I can confirm that this bug has existed for quite a while.

However it seems that it mostly appears after a file has been edited and saved using EasyTag at least two times. First time may succeed without noticeable problems.


Steps to reproduce:

======
Step 0

0a) Create a reference file: Use Audacity to generate a sine tone, e.g. 3 seconds of 440 Hz. Export as ogg, sine.ogg. You may want to create a read only backup copy of the file as a base line and source for further testing.

0b) Check the ogg file using ogginfo:
#ogginfo sine.ogg

output:
...
	TITLE=440 Hz sine
...

0c) Play the ogg file using ogg123
#ogg123 sine.ogg

No audible errors.

======
Step 1

1a) Edit the ogg file using EasyTAG, e.g. add an artist and date. Save the file.

1b) Check the ogg file again using ogginfo:
#ogginfo sine.ogg

output:
...
	TITLE=440 Hz sine
	ARTIST=audacity
	DATE=2017
...

1c) Play the off file using ogg123
#ogg123 sine.ogg

No audible errors.

======
Step 2

2a) Re-edit the ogg file using EasyTAG, e.g. add a track number. Save the file.

2b) Check the ogg file using ogginfo:
#ogginfo sine.ogg
output:
...
	TITLE=440 Hz sine
	ARTIST=audacity
	DATE=2017
	TRACKNUMBER=01
	TRACKTOTAL=01
Negative or zero granulepos (-335) on Vorbis stream outside of headers. This file was created by a buggy encoder
...


2c) Play the ogg file using ogg123
#ogg123 sine.ogg

Error(s) should be audible.

2d) Open file in Audacity. Changes to the sine waveform are visible upon zoom in.

Still reproducible on easytag-2.4.3-12.fc34.x86_64

This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

This serious data-damaging bug has been open for far too long. Whilst it's clear that this should be fixed upstream (and upstream seems largely dead), what is standing in the way of temporarily applying the known-good patch which OpenSuSE has been carrying for over 3 years?

Here's the pull request: https://src.fedoraproject.org/rpms/easytag/pull-request/1

If none of the maintainers is willing to apply this downstream patch, I offer to do the work in Fedora if granted access to do it. (username: timj)

For the record, I took the patch from https://build.opensuse.org/package/view_file/GNOME:Apps/easytag/easytag-revert-open-handle-ogg.patch and applied it to the sources of easytag-2.4.3-12.fc34. Rebuilt cleanly and appears to solve the issue:

# with 2.4.3-12.fc34
ffmpeg -f lavfi -i "sine=frequency=1000:duration=5" -ac 2 sine.wav
oggenc sine.wav
[...]
oggz-validate sine.ogg
# ok
easytag .&
[edit track number in sine.ogg to "1", save]
oggz-validate sine.ogg
# ok
[edit track number in sine.ogg to "2", save]
oggz-validate sine.ogg
-00:00:00.007: serialno 1130217793: Packet out of order (previous 00:00:00.033)
-00:00:00.007: serialno 1130217793: Granulepos decreasing within track

# patched with easytag-revert-open-handle-ogg.patch -p1 -R
ffmpeg -f lavfi -i "sine=frequency=1000:duration=5" -ac 2 sine.wav
oggenc sine.wav
[...]
oggz-validate sine.ogg
# ok
easytag .&
[edit track number in sine.ogg to "1", save]
oggz-validate sine.ogg
# ok
[edit track number in sine.ogg to "2", save]
oggz-validate sine.ogg
#ok

After the patch, I am unable to trigger the creation of a corrupt file despite edited various tags, adding/removing cover art etc.

This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

The problem still present in easytag-2.4.3-14.fc36.x86_64.

I discovered this problem when some of my OGG files wouldn't get detected by plex on Fedora 36. At first I thought it was a problem with ffmpeg because gstreamer would still play them. Then I looked deeper to try and debug gstreamer and noticed the OGG headers had been repeated. Since I had recently ripped them with asunder I repeated the process and noticed the freshly ripped files didn't have the extra headers but only got them after I adjusted the tags using easytag.  I pulled from the repo created here a week ago: https://github.com/maazl/easytag and then updated its configure script and the makefile.am/in files so that the appdata check passed.  I also renamed some of the icon/appdata info but I wasn't 100% successful since the app icon doesn't show up but I did end up successfully making an rpm for fedora 36 where this issue no longer occurs.  I think at a minimum the opensuse patch above should be considered or at least disable the use of easytag for OGG files since its corrupting them.

This message is a reminder that Fedora Linux 36 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '36'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 36 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Fedora Linux 36 entered end-of-life (EOL) status on 2023-05-16.

Fedora Linux 36 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

The problem is still present in easytag-2.4.3-18.fc38.x86_64. See below.

I have followed the steps in post by Tim Jackson of 2022-01-14 22:28:40 UTC to recreate the error on
Fedora Linux 38 Workstation Edition (x86-64), 6.2.15-300.fc38.x86_64

[create sine.wav using ffmpeg and encode it as sine.ogg using oggenc and validate file using oggz-validate]
ffmpeg -f lavfi -i "sine=frequency=1000:duration=5" -ac 2 sine.wav
oggenc sine.wav
oggz-validate sine.ogg
[output: nothing (=no errors found)]

[1st easytag edit: add track number 1 to sine.ogg, save and exit easytag, validate sine.ogg again using oggz-validate]
easytag .&
oggz-validate sine.ogg
[output: nothing (=no errors found)]

[2nd edit: change track number to 2, save and exit easytag, validate sine.ogg again using oggz-validate]
easytag .&
oggz-validate sine.ogg
sine.ogg: Error:
-00:00:00.007: serialno 1925726919: Packet out of order (previous 00:00:00.033)
-00:00:00.007: serialno 1925726919: Granulepos decreasing within track

Please reopen bug record, if possible

Same problem with easytag-2.4.3-19.fc39.x86_64

(In reply to Adrien D from comment #18)
> Same problem with easytag-2.4.3-19.fc39.x86_64

Including the patch in my copr : https://copr.fedorainfracloud.org/coprs/adriend/fedora-apps/build/6773502/

Tested to update tags : all is okay. The patch works

Is it possible to add this patch please ?
I think no new version for Easytag planned ... because the actual version released 7 years ago !!!!

This message is a reminder that Fedora Linux 38 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 38 on 2024-05-21.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '38'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 38 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

The issue still present in Fedora 40