Bug 1893711

Summary:	Review request: mamba - virtual midi keyboard
Product:	[Fedora] Fedora	Reporter:	ycollet <ycollette.nospam>
Component:	Package Review	Assignee:	Vasiliy Glazov <vascom2>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, pampelmuse, vascom2
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	vascom2: fedora-review? vascom2: needinfo+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-13 08:35:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description ycollet 2020-11-02 12:24:26 UTC

I packaged a new package for Mamba.
Mamba is a vrtual midi keyboard compatible with ALSAL and Jack Audio.
You can read more informations related to mamba on the github repository:
https://github.com/brummer10/Mamba

The specfile:
https://raw.githubusercontent.com/ycollet/fedora-spec/master/guitarix/mamba.spec

The SRPMS file:
https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-33-x86_64/01741589-mamba/mamba-1.7.0-2.fc33.src.rpm

Comment 1 Vasiliy Glazov 2020-11-07 04:24:14 UTC

Please remove mamba_source.sh script and make all sources with direct urls.
Submodule should be packaged separately.

Comment 2 ycollet 2020-11-24 07:40:13 UTC

Upstream is now providing a tar.gz with all the submodule inside. So, now I download it directly.

Comment 3 ycollet 2020-11-24 19:21:13 UTC

obody seems to be interested ...
So, I close the package review.
Somebody else will had back this if somebody at fedora is interested.

Comment 4 Vasiliy Glazov 2020-11-27 07:20:23 UTC

So you will provide updated SPEC and Srpm?

Comment 5 ycollet 2020-11-27 07:23:42 UTC

Yes, the last build is against version 1.9 of mamba:
https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-33-x86_64/01786444-mamba/mamba-1.9-4.fc33.src.rpm

And the spec file is here:
https://raw.githubusercontent.com/ycollet/fedora-spec/master/guitarix/mamba.spec

I added upstream tar.gz artifact which includes all the includes (with submodules).

Comment 6 Vasiliy Glazov 2020-11-27 07:49:23 UTC

What is libsmf package?

DEBUG util.py:634:  No matching package to install: 'libsmf-devel'
DEBUG util.py:634:  Not all dependencies satisfied
DEBUG util.py:634:  Error: Some packages could not be found.

Comment 7 ycollet 2020-11-27 07:53:18 UTC

Ah, yes, it's a library which allows to read / write MIDI files.
I opened a package review here for this library:
https://bugzilla.redhat.com/show_bug.cgi?id=1895696

Comment 8 Vasiliy Glazov 2020-11-27 08:01:27 UTC

OK.
Just fix issues at libsmf review and request approve from reviewer. After that I make you maintainer and you will add libsmf to the repos.

At this review please fix next:

1. bogus date in %changelog: Thu Nov 24 2020
It was Tue.

Comment 9 ycollet 2020-11-27 08:13:52 UTC

OK, I will commit a fix tonight.
I missed this one ... :)

Comment 10 ycollet 2020-11-27 20:37:00 UTC

Here is the modified spec file:
https://raw.githubusercontent.com/ycollet/fedora-spec/master/libsmf/libsmf.spec

And the correspond src rpm file:
https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-33-x86_64/01798070-libsmf/libsmf-1.3-6.fc33.src.rpm

I fixed the wrong date. I applied rpmlint to the spec file and no errors shows up.

Comment 11 Vasiliy Glazov 2020-11-27 20:47:07 UTC

OK. Now let's wait libsmf approve.