Bug 1893982

Summary:	Leapp should detect CIFS mounts in /etc/fstab
Product:	Red Hat Enterprise Linux 7	Reporter:	Christophe Besson <cbesson>
Component:	leapp-repository	Assignee:	Leapp team <leapp-notifications>
Status:	CLOSED ERRATA	QA Contact:	Alois Mahdal <amahdal>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.9	CC:	fkrska, mlitwora, pstodulk
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	leapp-repository-0.15.0-1.el7_9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-10 09:13:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1818077, 1818088

Description Christophe Besson 2020-11-03 09:13:34 UTC

Description of problem:
Leapp fails while running "mount -a" when there is a CIFS entry in /etc/fstab.
It's likely due to the DNS resolution. This kind of entries could be ignored, like NFS ones.

Version-Release number of selected component (if applicable):
leapp-repository-0.11.0-4.el7_9.noarch

How reproducible:
100% for the customer

Steps to Reproduce:
1. Add a CIFS entry with a hostname in /etc/fstab
2. Proceed to the upgrade

Actual results:
upgrade[679]: CalledProcessError: Command ['/bin/mount', '-a'] failed with exit code 32.
:
upgrade[679]: Container sysroot failed with error code 1.
upgrade[679]: writing logs to disk and rebooting
upgrade[679]: /bin/upgrade: line 19: /sysroot/var/tmp/system-upgrade.state: Read-only file system
systemd[1]: upgrade.service: Main process exited, code=exited, status=1/FAILURE
:
upgrade[1951]: mount error: could not resolve address for ab.cd.ef.net: Unknown error

Additional info:
Commenting out this entry for the time of the upgrade easily fixes the issue.

Comment 2 Petr Stodulka 2020-11-03 09:32:07 UTC

Currently, we require all partitions in /etc/fstab has to be local and mountable using "mount -a" for the upgrade. CIFS doesn't meet this condition by nature of CIFS. Until the networking will be working during the "upgrade initramfs" phases, only valid (and duable) solution from our side I can see is detection of CIFS and inhibit the upgrade. Only valid way for user in this case (and expected now) is to comment out CIFS partitions in /etc/fstab before the upgrade (before the run of `leapp upgrade`) and set it back after the upgrade.

Comment 3 Christophe Besson 2020-11-03 09:40:43 UTC

Thanks Petr for modifying the expectation, yes it should be inhibited.

Comment 4 Petr Stodulka 2021-01-28 11:43:00 UTC

The PR with the fix:
    https://github.com/oamg/leapp-repository/pull/632

unfortunately, regarding the current deadline, we are not sure whether the fix will be present in the upcoming release.

Comment 7 Petr Stodulka 2021-07-07 15:39:23 UTC

The fix has been merged in the upstream, so it will be part of the next release.

Comment 13 errata-xmlrpc 2021-11-10 09:13:09 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (leapp, leapp-repository, and cockpit-leapp bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4603