Bug 1894293

Summary:	Update migration controller container name to 'mtc' from 'cam'
Product:	Migration Toolkit for Containers	Reporter:	John Matthews <jmatthew>
Component:	General	Assignee:	Jason Montleon <jmontleo>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:	Avital Pinnick <apinnick>
Priority:	unspecified
Version:	1.3.0	CC:	ernelson, rjohnson, sregidor
Target Milestone:	---
Target Release:	1.4.0
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/konveyor/mig-operator/pull/528
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 12:54:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1907415
Bug Blocks:

Description John Matthews 2020-11-03 22:58:33 UTC

Description of problem:

The controller's container name is 'cam' and not 'mtc'.

$ oc logs migration-controller-65fcc9bfd-btgrt
Error from server (BadRequest): a container name must be specified for pod migration-controller-65fcc9bfd-btgrt, choose one of: [cam discovery]



Version:
Seen in MTC 1.3.1 and looks to present still in upstream github

https://github.com/konveyor/mig-operator/blob/master/roles/migrationcontroller/templates/controller.yml.j2#L106

Comment 1 Jason Montleon 2020-12-11 23:42:12 UTC

I'll take a look at this Monday. I am concerned that if we do this we're going to end up with a cam and mtc container on upgrade. If that's the case we'll have to add some additional logic to handle that situation.

Comment 2 Jason Montleon 2020-12-14 14:42:40 UTC

As expected this resulted in an mtc and cam container on upgrade. I added some logic to detect the old 'cam' container and delete the deployment before recreating it in case it exists.

Comment 7 Sergio 2020-12-22 10:41:00 UTC

Verified using MTC 1.4.0

openshift-migration-rhel7-operator@sha256:236d5f964061938f4e845e6d9e62926da68435c0f0304329a0473e060cdb53f1

    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 5671667a75e12cd538a34c208bfb076534296cdf91f7e97ef48fc59f8ce3c172



$ oc logs migration-controller-f7999c7fd-chzpm 
error: a container name must be specified for pod migration-controller-f7999c7fd-chzpm, choose one of: [mtc discovery]

Comment 9 errata-xmlrpc 2021-02-11 12:54:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329