Bug 1894412

Summary:	[RFE][External] RGW metrics should be made available even if anything else except 9283 is provided as the monitoring-endpoint-port
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Rachael <rgeorge>
Component:	rook	Assignee:	Sébastien Han <shan>
Status:	CLOSED ERRATA	QA Contact:	Sidhant Agrawal <sagrawal>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.6	CC:	amohan, assingh, bkunal, dwalveka, ebenahar, etamir, jthottan, madam, muagarwa, nberry, ocs-bugs, sagrawal, shan
Target Milestone:	---	Keywords:	AutomationBackLog, FutureFeature
Target Release:	OCS 4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.7.0-731.ci	Doc Type:	Enhancement
Doc Text:	.Allow the configuration of the Service monitor port to differ from the default ceph-mgr Prometheus port. With this enhancement, if the external Ceph cluster is configured with a `ceph-mgr` Prometheus module listening on the non-default port (9283) then OpenShift Container Storage now can connect and consume those metrics, that is, the OpenShift Container Storage now accepts any monitoring port.	Story Points:	---
Clone Of:	1890971
Clones:	1902192 1904105 (view as bug list)		Environment:
Last Closed:	2021-05-19 09:16:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1921864
Bug Blocks:	1902192, 1904105, 1938134

Comment 7 Mudit Agarwal 2021-02-16 11:09:52 UTC

To enable this behaviour we need fix in rook and ocs-operator, this BZ is to track rook changes while the BZ to track ocs- operator changes is https://bugzilla.redhat.com/show_bug.cgi?id=1902192
Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1902192 is available with 4.7.0-722.ci, can you please retest with that version.

Moving it back to ON_QA

Comment 8 Mudit Agarwal 2021-02-16 11:19:51 UTC

My bad, we still need to change the script in order for this fix to work. 
Can you please raise a new BZ to track the script part?

Arun, PTAL

Comment 9 Rachael 2021-02-16 11:26:32 UTC

Moving the bug back to assigned.

Comment 10 Sébastien Han 2021-02-16 12:00:25 UTC

Oops, missed that, fix sent.

Comment 11 arun kumar mohan 2021-02-16 12:26:03 UTC

As Sebastien had made the changes, removing the 'NEED_INFO' on me.

Comment 13 Sébastien Han 2021-02-18 13:14:56 UTC

Done.

Comment 16 Sébastien Han 2021-03-10 10:31:20 UTC

Sidhant,

It's expected, OCS will **always** have the service on 9283 but point to the correct external port which in your case is 9092.  Is there anything not working?
If Prometheus is happy and can collect metrics properly then this is **not** failed QA.

Comment 20 Sébastien Han 2021-04-27 06:34:48 UTC

LGTM.

Comment 22 errata-xmlrpc 2021-05-19 09:16:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2041