Bug 1895150

Summary:	Review Request: rubiks - Rubiks cube solvers
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Dominik 'Rathann' Mierzejewski <dominik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Flags:	dominik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-01-22 23:27:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2020-11-05 22:00:46 UTC

Spec URL: https://jjames.fedorapeople.org/rubiks/rubiks.spec
SRPM URL: https://jjames.fedorapeople.org/rubiks/rubiks-20070912-1.fc34.src.rpm
Fedora Account System Username: jjames
Description: This package contains several different Rubik's cube solvers.  They can be invoked from the command line or used through sagemath.

Michael Reid (GPL+)

-  optimal - uses many pre-computed tables to find an optimal
   solution to the 3x3x3 Rubik's cube

Dik T. Winter (MIT)

-  dikcube - uses Kociemba's algorithm to iteratively find a short
   solution to the 3x3x3 Rubik's cube
-  size222 - solves a 2x2x2 Rubik's cube

Eric Dietz (GPLv2+)

-  cu2 - A fast, non-optimal 2x2x2 solver
-  cubex - A fast, non-optimal 3x3x3 solver
-  mcube - A fast, non-optimal 4x4x4 solver

Comment 1 Dominik 'Rathann' Mierzejewski 2020-11-06 08:53:19 UTC

koji scratch build succeeds: https://koji.fedoraproject.org/koji/taskinfo?taskID=55032911

(relevant) rpmlint output:
rubiks.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rubiks/cu2-readme.txt
rubiks.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rubiks/mcube-readme.txt

Please fix.

Are you sure that Michael Reid's code is under GPL+? reid/license.txt has the following statement:

#  Distributed under the terms of the GNU General Public License
#                         (GPL), version 2 or later.

I think you might have mixed up Michael Reid's and Eric Dietz's code.
The latter has the following in license.txt:
"They are, for the moment, released GPL"

Other than that, this looks good, so APPROVED.

Also, you could run some of the programs as a basic sanity check in %check, e.g.:
%check
for v in cu2 cubex mcube ; do
echo | rubiks_${v} random
done

Comment 2 Jerry James 2020-11-10 18:27:51 UTC

(In reply to Dominik 'Rathann' Mierzejewski from comment #1)
> (relevant) rpmlint output:
> rubiks.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/rubiks/cu2-readme.txt
> rubiks.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/rubiks/mcube-readme.txt
> 
> Please fix.

I actually had a sed invocation in %prep to do this, but managed to typo it.  Fixed.

> I think you might have mixed up Michael Reid's and Eric Dietz's code.

Yes, I sure did.  Good catch!  Fixed.

> Also, you could run some of the programs as a basic sanity check in %check,
> e.g.:
> %check
> for v in cu2 cubex mcube ; do
> echo | rubiks_${v} random
> done

Done.  Thank you very much for the review.  This is what I will actually import into git:

Spec URL: https://jjames.fedorapeople.org/rubiks/rubiks.spec
SRPM URL: https://jjames.fedorapeople.org/rubiks/rubiks-20070912-2.fc34.src.rpm

Comment 3 Gwyn Ciesla 2020-11-10 19:03:09 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubiks

Comment 4 Fedora Update System 2020-11-16 16:12:29 UTC

FEDORA-2020-f16abf2fb5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5

Comment 5 Fedora Update System 2020-11-17 02:34:03 UTC

FEDORA-2020-f16abf2fb5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f16abf2fb5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-11-19 15:41:18 UTC

FEDORA-2020-f16abf2fb5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5

Comment 7 Fedora Update System 2020-11-19 17:15:51 UTC

FEDORA-2020-f16abf2fb5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5

Comment 8 Fedora Update System 2020-11-20 02:14:42 UTC

FEDORA-2020-f16abf2fb5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f16abf2fb5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f16abf2fb5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-11-30 01:08:37 UTC

FEDORA-2020-f16abf2fb5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Dominik 'Rathann' Mierzejewski 2021-01-22 23:27:18 UTC

Looks like this was never closed properly.