Bug 1895447

Summary: Wrong version in pkgconfig for nss-devel
Product: [Fedora] Fedora Reporter: Dmitry Butskoy <dmitry>
Component: nssAssignee: Daiki Ueno <dueno>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideCC: crypto-team, dueno, elio.maldonado.batiz, kai-engert-fedora, kdudka
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-10 15:21:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dmitry Butskoy 2020-11-06 17:12:41 UTC
Latest nss-devel's file /usr/lib64/pkgconfig/nss.pc is:
```
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib64
includedir=/usr/include/nss3

Name: NSS
Description: Network Security Services
Version: 4.29.0
Requires: nspr >= 4.29.0, nss-util >= 3.58.0
Libs: -L${libdir} -lssl3 -lsmime3 -lnss3
Cflags: -I${includedir}
```

Note the version of 4.29.0, instead of 3.58.0

The problem is here:
https://src.fedoraproject.org/rpms/nss/blob/master/f/nss.spec#_479
because the %{version} macro expanded to the *latest* Version tag in the spec file, which (in this case) is related to nspr version, not nss...

IOW, s/%{version}/%{nss_version}/ there.

Comment 1 Daiki Ueno 2020-11-06 17:26:28 UTC
Thank you for the report; yes, this is really bad.

I guess we should probably use the same versioning for both nspr and nss (i.e., we should rename nspr to nspr429 or something and use the nss version number).

Comment 2 Daiki Ueno 2020-11-10 15:21:49 UTC
For the meantime, I applied your suggestion (s/%{version}/%{nss_version}/). Thank you for that!
https://src.fedoraproject.org/rpms/nss/c/a0090873a5b47a896b574ea437c5d3b8d0f6c2e4?branch=master