Bug 1895695

Summary: Modifying (add/remove/replace) NICs in the clone modal doesn't reflect on the cloned VM
Product: [oVirt] ovirt-engine Reporter: Tamir <tamir>
Component: BLL.VirtAssignee: Shmuel Melamud <smelamud>
Status: CLOSED CURRENTRELEASE QA Contact: Tamir <tamir>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.4.3.10CC: ahadas, bugs
Target Milestone: ovirt-4.4.4Keywords: Regression
Target Release: 4.4.4.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.4.4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-12-21 12:36:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Added recorded GIF none

Description Tamir 2020-11-08 13:35:18 UTC 
Created attachment 1727569 [details]
Added recorded GIF

Description of problem:
When I clone any VM and in the clone modal adding/replacing/removing NICs the cloned VM gets the same number and networks as the base VM.

Version-Release number of selected component (if applicable):
RHV 4.4.3-13 (ovirt-engine.noarch 4.4.3.10-0.1.el8ev)
RHEL 8.3 x86 hosts and engine.
vdsm.x86_64 4.40.35.1-1.el8ev on the hosts.

How reproducible:
100%

Steps to Reproduce:
1. Create a 4.5 data center and a 4.5 cluster.
2. Install the host and create a new NFS storage domain.
3. Create a VM with a disk and a NIC and wait for its creation.
4. Clone the VM and in the clone modal add another NIC and replace the first NIC.
5. Check the cloned VM nics are as expected.

Actual results:
1. The 4.5 data center and the 4.5 cluster were created.
2. The host was installed and the NFS storage domain was created.
3. The VM with the disk was created.
4. The cloned VM was created.
5. The cloned VM doesn't contain the NIC changes we declared, it contains the same NICs as for base VM.

Expected results:
Steps 1-4 were executed as expected.
5 - The cloned VM's NICs should be the same as we declared in the clone modal. 

Additional info:
Comment 1 Tamir 2020-11-08 13:36:46 UTC 
Comment on attachment 1727569 [details]
Added recorded GIF

There's a problem with the GIF... 

It doesn't show anything.
Comment 2 Tamir 2020-12-13 14:32:32 UTC 
Verified on RHV 4.4.4-5. All looks good to me.

Env:
  - Engine instance with RHV 4.4.4-5 (ovirt-engine-4.4.4.4-0.9.el8ev) and RHEL 8.3 installed.
  - 2 hosts with RHV 4.4.4-5 and RHEL 8.3, three hosts with vdsm-4.40.40-1.el8ev

Steps:

In Admin Portal:

Steps to Reproduce:
1. Create a 4.5 data center and a 4.5 cluster.
2. Install the host and create a new NFS storage domain.
3. Create a VM with a disk and a NIC and wait for its creation.
4. Clone the VM and in the clone modal add another NIC and replace the first NIC.
5. Check the cloned VM nics are as expected.
6. Clone the same VM and in the clone modal remove all NICs.
7. Check that the are no nics attached to the cloned VM.

Results (As Expected):
1. The 4.5 data center and the 4.5 cluster were created.
2. The host was installed and the NFS storage domain was created.
3. The VM with the disk was created.
4. The cloned VM was created.
5. The cloned VM's NICs are the same as we declared in the clone modal. 
6. The cloned VM was created.
7. There were no nics attached to the cloned VM.
Comment 3 Sandro Bonazzola 2020-12-21 12:36:49 UTC 
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.