Bug 1896245

Summary: [CBT][RFE] Use the new VIR_ERR_CHECKPOINT_INCONSISTENT error from libvirt to identify invalid checkpoints
Product: [oVirt] ovirt-engine Reporter: Eyal Shenitzky <eshenitz>
Component: BLL.StorageAssignee: Eyal Shenitzky <eshenitz>
Status: CLOSED CURRENTRELEASE QA Contact: Ilan Zuckerman <izuckerm>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.4.3CC: bugs, dfodor, nsoffer, sfishbai, tnisan
Target Milestone: ovirt-4.4.5Keywords: FutureFeature
Target Release: ---Flags: pm-rhel: planning_ack?
pm-rhel: devel_ack?
pm-rhel: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-18 15:13:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2020-11-10 07:11:18 UTC
Description of problem:

In Libvit >= 6.10, a new error is raised in case of trying to do backup related operations
with a broken checkpoint - VIR_ERR_CHECKPOINT_INCONSISTENT.

The engine/VDSM should identify this error and act accordingly in case it is raised.

Version-Release number of selected component (if applicable):
4.4.4_master

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Shir Fishbain 2021-01-26 11:37:04 UTC
Hi Eyal,
Please provide info on how to verify it correctly.

Comment 2 Eyal Shenitzky 2021-01-26 12:13:41 UTC
(In reply to Shir Fishbain from comment #1)
> Hi Eyal,
> Please provide info on how to verify it correctly.

Can be verified by running the regular tiers in the automation.

Comment 3 Ilan Zuckerman 2021-02-08 07:06:15 UTC
Eyal, in order to verify this, I'd like to know:
- How to raise this ERROR
- How the engine should act when this ERROR is raised

Comment 4 Eyal Shenitzky 2021-02-08 11:56:47 UTC
(In reply to Ilan Zuckerman from comment #3)
> Eyal, in order to verify this, I'd like to know:
> - How to raise this ERROR
> - How the engine should act when this ERROR is raised

In order to verify that bug we can just run the regular tiers.
There is no specific flow that should be checked.

Comment 5 Ilan Zuckerman 2021-02-09 11:49:33 UTC
Moving this on verified based on the tier1 and tier2  (tier3 doesnt exist) Automated test cases of CBT which were executed on latest rhv-4.4.5-4
tier2 was executed locally, tier1 is "RHV-4.4-tier1 #154" and can be found in Polarion.
No regression was spotted, or suspicious behavior. All test cases passed (except for known issues BZ 1914636 and BZ 1849861)

Comment 6 Sandro Bonazzola 2021-03-18 15:13:01 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.

Comment 7 Sandro Bonazzola 2021-03-22 12:55:33 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.