Bug 1896795

Summary:	Upstream Disk API documentation doesn't specify the "cache" string format
Product:	Container Native Virtualization (CNV)	Reporter:	Jed Lejosne <jlejosne>
Component:	Virtualization	Assignee:	Hao Yu <hayu>
Status:	CLOSED ERRATA	QA Contact:	Israel Pinto <ipinto>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.6.0	CC:	acardace, cnv-qe-bugs, fdeutsch, hayu, kbidarka, sgott
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hco-bundle-registry-container-v4.8.0-347 virt-operator-container-v4.8.0-58	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 14:21:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jed Lejosne 2020-11-11 14:49:28 UTC

Document URL: 
https://kubevirt.io/api-reference/master/definitions.html#_v1_disk

Section Number and Name: 
v1.Disk

Describe the issue: 
The disk API documentation doesn't state the possible values for the "cache" disk parameter.

Suggestions for improvement: 
Add a list of valid strings or a string format to be able to use the option.

Additional information:

Comment 1 Hao Yu 2021-03-09 21:58:18 UTC

Upstream PR, https://github.com/kubevirt/kubevirt/pull/5183, is submitted to address the issue. 

The supported values for v1.Disk cache mode are: CacheNone, CacheWriteThrough.

Comment 2 Hao Yu 2021-03-24 18:31:35 UTC

PR #5183 at https://github.com/kubevirt/kubevirt/pull/5183 addresses this bug and it has been merged upstream.

Comment 3 Hao Yu 2021-03-24 18:34:46 UTC

CC: sgott

Comment 4 Israel Pinto 2021-05-26 16:33:14 UTC

https://kubevirt.io/api-reference/master/definitions.html#_v1_disk
The cache option have the expected values: 
"
Cache specifies which kvm disk cache mode should be used. Supported values are: CacheNone, CacheWriteThrough.
"

Comment 7 errata-xmlrpc 2021-07-27 14:21:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.0 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2920