Bug 1896829
| Summary: | c&p issue on netlink parsing of mpls match info from tc | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Fast Datapath | Reporter: | Marcelo Ricardo Leitner <mleitner> |
| Component: | openvswitch2.13 | Assignee: | Eelco Chaudron <echaudro> |
| Status: | CLOSED UPSTREAM | QA Contact: | ovs-qe |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | FDP 20.I | CC: | ctrautma, fhallal, fleitner, jhsiao, ralongi |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-15 15:18:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1503503 | ||
Looks like this is used by the revalidator threads, so no easy way to add a test case. Did some manual verification and sent out a patch: https://mail.openvswitch.org/pipermail/ovs-dev/2020-November/377845.html Closing BZ, as the patch has been accepted, and backported all the way down to 2.11. Our FDP build will pick this up automatically. https://patchwork.ozlabs.org/project/openvswitch/patch/160629789572.654506.8925891937212444408.stgit@ebuild/ Commit: * 0f252daa94 tc: Fix mpls bottom of stack bit mask reporting. |
Description of problem: AFAIK this only affects how the match is reported back, once added. It propagates at least up to netdev_tc_flow_get() which is .flow_get method. Not sure if can propagate differently from there on. Fixes: 34b1695506f8 ("lib/tc: add single mpls match offload support") diff --git a/lib/tc.c b/lib/tc.c index 8761304c92bb..af201b0c09fa 100644 --- a/lib/tc.c +++ b/lib/tc.c @@ -517,7 +517,7 @@ nl_parse_flower_mpls(struct nlattr **attrs, struct tc_flower *flower) if (attrs[TCA_FLOWER_KEY_MPLS_BOS]) { bos = nl_attr_get_u8(attrs[TCA_FLOWER_KEY_MPLS_BOS]); set_mpls_lse_bos(&flower->key.mpls_lse, bos); - set_mpls_lse_ttl(&flower->mask.mpls_lse, 0xff); + set_mpls_lse_bos(&flower->mask.mpls_lse, 0xff); } if (attrs[TCA_FLOWER_KEY_MPLS_TC]) { Version-Release number of selected component (if applicable): ovs git master