Bug 1896852
| Summary: | Review Request: golang-github-facebook-ent - An entity framework for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Olivier Lemasle <o.lemasle> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | o.lemasle, package-review |
| Target Milestone: | --- | Flags: | o.lemasle:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-29 01:13:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2020-11-11 17:01:59 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=55398774 Thank you Davide. Please fix these rpmlint errors: golang-github-facebook-ent-docs.x86_64: E: description-line-too-long C The package golang-github-facebook-ent-docs contains documentation and examples for golang-github-facebook-ent. golang-github-facebook-ent-docs.x86_64: E: version-control-internal-file /usr/share/doc/golang-github-facebook-ent-docs/doc/.gitignore golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/.gitignore golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/aggregate.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/code-gen.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/crud.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/dialects.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/getting-started.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/hooks.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/migrate.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/paging.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/predicates.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-annotations.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-def.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-edges.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-fields.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-indexes.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/schema-mixin.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/transactions.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/md/traversals.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/README.md golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/core/Footer.js golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/pages/en/index.js golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/sidebars.json golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/static/css/custom.css golang-github-facebook-ent-docs.x86_64: W: spurious-executable-perm /usr/share/doc/golang-github-facebook-ent-docs/doc/website/static/img/oss_logo.png The golang-github-facebook-ent-docs can simply be split over multiple lines (should not exceed 79 characters/line). The .gitignore file should be removed, and the .md files should be chmod to remove execution permission. Furtheremore, the golang-github-facebook-ent-devel package does not contain the examples, but does contain their README files: /usr/share/gocode/src/github.com/facebook/ent/examples/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/edgeindex/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/entcpkg/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2m2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2mbidi/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/m2mrecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2m2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2mrecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2o2types/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2obidi/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/o2orecur/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/privacyadmin/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/privacytenant/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/start/README.md /usr/share/gocode/src/github.com/facebook/ent/examples/traversal/README.md Thanks! I think rpmlint should be good now, but I couldn't figure out how to exclude doc and examples from the -devel package. I can forcibly remove them in %prep, but then the packaging fails because %gopkgfiles still includes them in the file list. I also tried using the gosupfilesex and godocsex macros but they don't seem to be doing anything either. Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-github-facebook-ent.spec SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-facebook-ent/golang-github-facebook-ent-0.5.0-2.fc34.src.rpm Changelog: - Fix docs permissions and remove spurious gitignore Package accepted. - licence ok - spec ok - naming ok - rpmlint ok I didn't find a way to remove the examples/*/README.md files either (actually, golist lists .md files even in ignored directories...), but this is not a problem. Thanks! $ fedpkg request-repo golang-github-facebook-ent 1896852 https://pagure.io/releng/fedora-scm-requests/issue/30817 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-facebook-ent FEDORA-2020-03c8d62f77 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-03c8d62f77 FEDORA-2020-f8d23cd796 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8d23cd796 FEDORA-2020-03c8d62f77 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-03c8d62f77 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-03c8d62f77 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-f8d23cd796 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f8d23cd796 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8d23cd796 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-f8d23cd796 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-03c8d62f77 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |