Bug 1897264
| Summary: | PyPAM fails to build with Python 3.10: Py_TYPE= needs to be replaced with Py_SET_TYPE | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | PyPAM | Assignee: | Miroslav Suchý <msuchy> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mhroncok, msuchy, thrnciar, tmraz |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-11-18 19:48:18 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1890881 | ||
The change was reverted in Python 3.10, because it caused too much trouble (the amount of affected Fedora packages was too big). Keeping this open for now, unit anew alpha version is out to test it out. This comment is mass posted in all relevant bugzillas. If you already worked upstream to fix the problem, please let them know about the revert. https://github.com/python/cpython/commit/0e2ac21dd I've patched Python 3.10 in our testing copr to include the revert. This package built fine. Sorry for the noise. |
PyPAM fails to build with Python 3.10.0a2. PAMmodule.c:678:32: error: lvalue required as left operand of assignment 678 | Py_TYPE(&PyPAMObject_Type) = &PyType_Type; | ^ At top level: PAMmodule.c:10:13: warning: ‘revision’ defined but not used [-Wunused-variable] 10 | static char revision[] = "$Id: PAMmodule.c,v 1.3 2007/04/18 03:55:11 rob Exp $"; | ^~~~~~~~ error: command '/usr/bin/gcc' failed with exit code 1 error: Bad exit status from /var/tmp/rpm-tmp.wUHXmu (%build) https://docs.python.org/3.10/whatsnew/3.10.html#id2 Since Py_TYPE() is changed to the inline static function, Py_TYPE(obj) = new_type must be replaced with Py_SET_TYPE(obj, new_type): see Py_SET_TYPE() (available since Python 3.9). For backward compatibility, this macro can be used: #if PY_VERSION_HEX < 0x030900A4 # define Py_SET_TYPE(obj, type) ((Py_TYPE(obj) = (type)), (void)0) #endif https://bugs.python.org/issue39573 For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01758976-PyPAM/ For all our attempts to build PyPAM with Python 3.10, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/PyPAM/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10: https://copr.fedorainfracloud.org/coprs/g/python/python3.10/ Let us know here if you have any questions. Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.