Bug 1897282

Summary: podman-wait requiring units for interval when it is documented as optional
Product: Red Hat Enterprise Linux 8 Reporter: Stephen Benjamin <stbenjam>
Component: podmanAssignee: Jindrich Novy <jnovy>
Status: CLOSED ERRATA QA Contact: Alex Jia <ajia>
Severity: low Docs Contact:
Priority: unspecified    
Version: 8.2CC: bbaude, dwalsh, jligon, jnovy, lsm5, mheon, pthomas, tsweeney, umohnani, ypu
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: podman-3.0.0-0.19.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 15:32:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Stephen Benjamin 2020-11-12 17:04:22 UTC
Description of problem:

podman-wait is requiring units for `-i`.

Example:

    podman wait -i 1000 5f1841b5522f
    Error: invalid argument "1000" for "-i, --interval" flag: time: missing unit in duration 1000

Man page for podman-wait makes no mention of units:


       --interval, -i=microseconds
         Microseconds to wait before polling for completion

Note, the upstream manpage in master branch on git is a little clearer, but even if says the units are optional:

    --interval, -i=duration

    Time interval to wait before polling for completion. A duration string is a
    sequence of decimal numbers, each with optional fraction and a unit suffix,
    such as "300ms", "-1.5h" or "2h45m". Valid time units are "ns", "us" (or "µs"),   
    "ms", "s", "m", "h". Time unit defaults to "ms".



Version-Release number of selected component (if applicable):

      podman-2.0.5-5.module+el8.3.0+8221+97165c3f.x86_64

      Note, I also see this behavior on Fedora 32's podman-2.1.1-7.fc32.x86_64.


How reproducible:

Always

Steps to Reproduce:
1. podman wait -i 1000 <container id>

Actual results:

Error

Expected results:

Defaults to milliseconds or microseconds, the existing documentation is conflicting.

Additional info:

Comment 1 Matthew Heon 2020-11-12 17:49:26 UTC
This is fixed upstream by https://github.com/containers/podman/pull/8093 - unfortunately, I think it's too late to get into 8.3.1, so the fix may not land in RHEL until 8.4.

Comment 2 Tom Sweeney 2020-11-13 00:48:38 UTC
Assigning to Jindrich for any packaging or BZ needs.  I'm fine with pushing this to RHEL 8.4.

Comment 6 Alex Jia 2021-02-09 06:18:30 UTC
I can reproduce the bug on podman-2.0.5-5.module+el8.3.0+8221+97165c3f.x86_64,
and verify it on 

# rpm -q podman crun runc
podman-2.0.5-5.module+el8.3.0+8221+97165c3f.x86_64
crun-0.14.1-2.module+el8.3.0+8221+97165c3f.x86_64
runc-1.0.0-68.rc92.module+el8.3.0+8221+97165c3f.x86_64

# podman container run -d quay.io/libpod/alpine sleep 1
Trying to pull quay.io/libpod/alpine...
Getting image source signatures
Copying blob 9d16cba9fb96 done
Copying config 9617696764 done
Writing manifest to image destination
Storing signatures
6db1149c4a3c5fe94024eb58dbf11a178e8e188d4834ae32b9b6f0043a7c374d

# podman wait -i 1000 6db1149c4a3c
Error: invalid argument "1000" for "-i, --interval" flag: time: missing unit in duration 1000

# rpm -q podman crun runc
podman-3.0.0-0.38rc2.module+el8.4.0+9804+5385893b.x86_64
crun-0.17-1.module+el8.4.0+9804+5385893b.x86_64
runc-1.0.0-70.rc92.module+el8.4.0+9804+5385893b.x86_64

# podman container run -d quay.io/libpod/alpine sleep 1
14d3994620df8743dab8aaff9da8f2349836b36917fd99829da499bbef0a23f9

# podman ps -a
CONTAINER ID  IMAGE                  COMMAND  CREATED        STATUS                    PORTS   NAMES
14d3994620df  quay.io/libpod/alpine  sleep 1  3 seconds ago  Exited (0) 2 seconds ago          beautiful_driscoll

# podman wait -i 1000 14d3994620df
0

Comment 8 errata-xmlrpc 2021-05-18 15:32:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: container-tools:rhel8 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1796