Bug 1897500

Summary: python-apsw fails to build with Python 3.10: Avoid using PyObject_AsCharBuffer(), PyObject_AsReadBuffer() and PyObject_AsWriteBuffer()
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-apswAssignee: Denis Fateyev <denis>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: denis, i, maci, mhroncok, thrnciar
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-apsw-3.35.4.r1-1.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-13 09:12:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881    

Description Tomáš Hrnčiar 2020-11-13 08:38:27 UTC
python-apsw fails to build with Python 3.10.0a2.

Traceback (most recent call last):
  File "/builddir/build/BUILD/apsw-3.33.0-r1/setup.py", line 907, in <module>
    setup(name="apsw",
  File "/usr/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib64/python3.10/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib64/python3.10/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python3.10/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/builddir/build/BUILD/apsw-3.33.0-r1/setup.py", line 130, in run
    import tests
  File "/builddir/build/BUILD/apsw-3.33.0-r1/tests.py", line 9, in <module>
    import apsw
ImportError: /builddir/build/BUILDROOT/python-apsw-3.33.0.r1-1.fc34.x86_64/usr/lib64/python3.10/site-packages/apsw.cpython-310-x86_64-linux-gnu.so: undefined symbol: PyObject_AsWriteBuffer

https://docs.python.org/3.10/whatsnew/changelog.html#id16

bpo-41103: PyObject_AsCharBuffer(), PyObject_AsReadBuffer(), PyObject_CheckReadBuffer(), and PyObject_AsWriteBuffer() are removed. Please migrate to new buffer protocol; PyObject_GetBuffer() and PyBuffer_Release().

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01757291-python-apsw/

For all our attempts to build python-apsw with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-apsw/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Fedora Update System 2020-12-20 22:30:59 UTC
FEDORA-2020-9b9107b8e0 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9b9107b8e0

Comment 2 Fedora Update System 2020-12-21 02:24:19 UTC
FEDORA-2020-9b9107b8e0 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-9b9107b8e0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9b9107b8e0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2020-12-29 01:17:45 UTC
FEDORA-2020-9b9107b8e0 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Tomáš Hrnčiar 2021-01-05 08:46:30 UTC
I am reopening this since python-apsw still doesn't build with Python 3.10

Traceback (most recent call last):
  File "/builddir/build/BUILD/apsw-3.34.0-r1/setup.py", line 908, in <module>
    setup(name="apsw",
  File "/usr/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib64/python3.10/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib64/python3.10/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python3.10/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/builddir/build/BUILD/apsw-3.34.0-r1/setup.py", line 130, in run
    import tests
  File "/builddir/build/BUILD/apsw-3.34.0-r1/tests.py", line 9, in <module>
    import apsw
ImportError: /builddir/build/BUILDROOT/python-apsw-3.34.0.r1-1.fc34.x86_64/usr/lib64/python3.10/site-packages/apsw.cpython-310-x86_64-linux-gnu.so: undefined symbol: PyObject_AsWriteBuffer

Full log: https://download.copr.fedorainfracloud.org/results/@python/python3.10/fedora-rawhide-x86_64/01854954-python-apsw/builder-live.log.gz

Comment 5 Ben Cotton 2021-02-09 15:24:02 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.