Bug 1897545

Summary: rebase unicode-emoji to 13.0 from Fedora 33
Product: Red Hat Enterprise Linux 8 Reporter: fujiwara <tfujiwar>
Component: unicode-emojiAssignee: Mike FABIAN <mfabian>
Status: CLOSED CURRENTRELEASE QA Contact: avdhoot <asagare>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.4CC: bbarve, eng-i18n-bugs, mfabian
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: unicode-emoji-13.0-4.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-12-03 06:53:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1897548    

Description fujiwara 2020-11-13 11:57:35 UTC
I'd request the later unicode-emoji to RHEL8 to get more emoji characters.

Comment 1 Jens Petersen 2021-05-04 04:26:05 UTC
This is needed for typing-booster to support Unicode 13 emoji?

Comment 2 Mike FABIAN 2021-06-14 06:01:42 UTC
(In reply to Jens Petersen from comment #1)
> This is needed for typing-booster to support Unicode 13 emoji?

Yes.

Comment 3 Mike FABIAN 2021-06-15 13:44:27 UTC
https://src.osci.redhat.com/rpms/unicode-emoji/pull-request/2 merged.

Comment 4 Mike FABIAN 2021-06-15 13:46:03 UTC
Related: rhbz#1897545 Remove trailing whitespace from gating.yaml

https://src.osci.redhat.com/rpms/unicode-emoji/c/e503b1ca4a514bdd512227eb7f77e9b03df95828?branch=rhel-8.5.0

rhpkg build complained:

$ rhpkg build 
Could not execute build: Found a gating.yaml file in your repo with additional Greenwave policies, but it is not valid.
Please fix the file or skip this check using the option --skip-remote-rules-validation.
Error response from Greenwave: YAML Parser Error: while scanning for the next token
found character '\t' that cannot start any token
  in "<unicode string>", line 3, column 11:
      - rhel-8	
              ^

Comment 8 Mike FABIAN 2021-06-16 10:07:07 UTC
It didn’t get through gating because osci.brew-build.tier0.functional didn’t run:

https://dashboard.osci.redhat.com/#/artifact/brew-build/aid/37495774

I have no idea why not, maybe because there is a missing newline at the end of gating.yaml??

I added a newline to gating.yaml and made a new build:

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=37517466

Comment 9 Mike FABIAN 2021-06-16 10:19:49 UTC
I asked on #osci and it seems to be the wrong file ending of the test file.
Another build:

 https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=37518118

commit 430fc673fb990f934cc9dd2fbbc450c8b04c1a6a (HEAD -> rhel-8.5.0, origin/rhel-8.5.0)
Author: Mike FABIAN <mfabian>
Date:   Wed Jun 16 12:15:13 2021 +0200

    Related: rhbz#1897545 rename: tests/tests.yaml -> tests/tests.yml

diff --git a/tests/tests.yaml b/tests/tests.yml
similarity index 100%
rename from tests/tests.yaml
rename to tests/tests.yml
diff --git a/unicode-emoji.spec b/unicode-emoji.spec
index 7a1c14d..48bae32 100644
--- a/unicode-emoji.spec
+++ b/unicode-emoji.spec
@@ -46,6 +46,9 @@ cp -p %{SOURCE6} %{buildroot}%{emojidir}
 %{emojidir}/emoji-*txt
 
 %changelog
+* Wed Jun 16 2021 Mike FABIAN <mfabian> - 13.0-3
+- Related: rhbz#1897545 rename: tests/tests.yaml -> tests/tests.yml
+
 * Wed Jun 16 2021 Mike FABIAN <mfabian> - 13.0-2
 - Related: rhbz#1897545 Add missing newline at the end of gating.yaml

Comment 10 Mike FABIAN 2021-06-16 13:33:57 UTC
It was still failing, so I rewrote some of the CI test:

https://src.osci.redhat.com/rpms/unicode-emoji/pull-request/3

Comment 11 Mike FABIAN 2021-06-16 13:35:37 UTC
Merged. New build:

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=37523215

Comment 12 Mike FABIAN 2021-06-16 14:55:20 UTC
Now all tests seem to have passed:

https://dashboard.osci.redhat.com/#/artifact/brew-build/aid/37523215

Comment 13 Mike FABIAN 2021-06-17 07:13:57 UTC
Now I could add the unicode-emoji-13.0-4.el8 to the errata https://errata.devel.redhat.com/advisory/77474

Comment 14 Mike FABIAN 2021-06-17 07:45:30 UTC
rpmdiff complains: 

Upstream version changed from 10.90.20180207 to 13.0 (not OK, because unicode-emoji is not on the version whitelist and no ET77474-linked bugs have the 'Rebase' keyword)

Comment 18 avdhoot 2021-07-12 08:46:09 UTC
Verified:tested bug on rhel8.5 with below ibus-package.

ibus-1.5.19-13.el8.x86_64

observation:
Need to use above ibus package to see upadted emojis.

Comment 19 avdhoot 2021-07-12 13:28:51 UTC
Verified with rhel8.5 nightly build
http://download.eng.bos.redhat.com/rhel-8/nightly/RHEL-8/RHEL-8.5.0-20210712.n.1


hence marking it as verified.