Bug 189756
| Summary: | dia: shouldn't own %_datadir/applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | dia | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | extras-qa |
| Target Milestone: | --- | Keywords: | EasyFix, Reopened |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-25 19:55:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Another small comment, why include in the .specfile: ---------------- # remove scrollkeeper stuff we don't include in the package rm -rf $RPM_BUILD_ROOT/var ---------------- But then call scrollkeeper-update in %%post/%%postun? Thanks! The desktop file wasn't installed correctly either, nor were the icons. This happens with package which come from Core :| About: # remove scrollkeeper stuff we don't include in the package rm -rf $RPM_BUILD_ROOT/var dia doesn't use scrollkeeper at all, so I've removed both these 2 lines and the scrollkeeper-update calls and requirements. I'll commit 0.95-0.pre9.1 soon and build it. Darn, My build just failed with unpackaged files under /var/scrollkeeper, I thought rpm checked for that earlier in the build then this. A well. Hasn't dia-0.9.5(final) been released as well? :) (In reply to comment #4) > Hasn't dia-0.9.5(final) been released as well? :) You're right 0.95 final has been released, thanks. About the scrollkeeper stuff it seems that dia does generate some scrollkeepr stuff under /var/lib/scrollkeeper during %install, but thats obsolete and it doesn't add any omf descriptions to /usr/share/omf, so I've dropped the scrollkeeper-update stuff and kept the rm -fr $RMP_BUILD_ROOT/var/lib/scrollkeeper 0.95 is building on the buildsys for devel as I type. Since 0.95 is final now and 0.94 has issue I'll push 0.95 to FC-5 too. |
dia (or any desktop app) shouldn't own %_datadir}/applications. %files should instead include: %{_datadir}/applications/*.desktop