Bug 1897614

Summary:	Performance search rate: change entry cache monitor to recursive pthread mutex
Product:	Red Hat Enterprise Linux 8	Reporter:	thierry bordaz <tbordaz>
Component:	389-ds-base	Assignee:	thierry bordaz <tbordaz>
Status:	CLOSED ERRATA	QA Contact:	RHDS QE <ds-qe-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	mreynolds, sgouvern
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	sync-to-jira
Fixed In Version:	389-ds-1.4-8050020210514191740-d5c171fc	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-09 18:10:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description thierry bordaz 2020-11-13 16:14:21 UTC

Description of problem:

Entry cache (entry and dn) are protected by a PRMonitor. Changing this Monitor into a recursive pthread mutex (cache aligned) increases throughput by 8%
Version-Release number of selected component (if applicable):


How reproducible:
search rate following https://www.port389.org/docs/389ds/development/performance-diagnostic.html


Actual results:
perf c2c shows some pressure on entry cache

Expected results:

Comment 2 sgouvern 2021-05-07 08:07:52 UTC

Moving to ITM 12, as we may not be ready for ITM 11

Comment 3 thierry bordaz 2021-05-10 07:16:43 UTC

Upstream ticket is https://github.com/389ds/389-ds-base/issues/4324. Fix is pushed upstream => POST

Comment 10 sgouvern 2021-06-28 14:57:39 UTC

build 389-ds-base-1.4.3.23-3.module+el8.5.0+11463+c476656c.x86_64.rpm planned for ITM 18 needs a respin - Moving to ITM 19

Comment 11 sgouvern 2021-07-08 12:43:16 UTC

Using the verification steps described in comment 4, on a 1minutetip machine flavor ocp-compute

With 389-ds-base from RHEL 8.4 released :

      Recent       Recent       Recent       Recent      Overall      Overall
Searches/Sec   Avg Dur ms Entries/Srch   Errors/Sec Searches/Sec   Avg Dur ms
------------ ------------ ------------ ------------ ------------ ------------
   46005.444        1.083        0.000        0.000    46005.422        1.083
   62168.899        0.800        0.000        0.000    54087.621        0.920
   67536.979        0.739        0.000        0.000    58570.257        0.851
   62332.137        0.800        0.000        0.000    59510.599        0.837
   59123.594        0.845        0.000        0.000    59433.191        0.839
   58018.758        0.860        0.000        0.000    59197.472        0.842
   64948.644        0.768        0.000        0.000    60019.000        0.831
   63143.314        0.791        0.000        0.000    60409.575        0.826
   50962.150        0.979        0.000        0.000    59359.958        0.840
   64378.489        0.776        0.000        0.000    59861.865        0.833

On the same machine, after ugrade to 389-ds-base-1.4.3.23-4.module+el8.5.0+11627+16aed726.x86_64 :

      Recent       Recent       Recent       Recent      Overall      Overall
Searches/Sec   Avg Dur ms Entries/Srch   Errors/Sec Searches/Sec   Avg Dur ms
------------ ------------ ------------ ------------ ------------ ------------
   71285.378        0.698        0.000        0.000    71285.354        0.698
   74967.067        0.664        0.000        0.000    73126.217        0.681
   68881.625        0.723        0.000        0.000    71711.398        0.694
   66930.307        0.746        0.000        0.000    70516.243        0.706
   71125.694        0.701        0.000        0.000    70638.146        0.705
   80089.682        0.623        0.000        0.000    72213.308        0.690
   79819.291        0.625        0.000        0.000    73299.964        0.680
   46655.620        1.070        0.000        0.000    69969.808        0.713
   76564.025        0.651        0.000        0.000    70702.562        0.705
   58813.063        0.849        0.000        0.000    69513.737        0.717

Throughput is better with 389-ds-base-1.4.3.23-4.module+el8.5.0+11627+16aed726.x86_64, marking verified : tested

Comment 15 errata-xmlrpc 2021-11-09 18:10:45 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (389-ds-base bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4203