Bug 1898108

Summary:	Foreman-Maintain should check disk space for new rh-postgresql12-postgresql-server before starting upgrade to Sat6.8
Product:	Red Hat Satellite	Reporter:	Kenny Tordeurs <ktordeur>
Component:	Satellite Maintain	Assignee:	Amit Upadhye <aupadhye>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.7.0	CC:	ahumbe, apatel, aupadhye, egolov, gtalreja, kgaikwad, mkalyat, mmccune, pmoravec, sokeeffe
Target Milestone:	6.10.0	Keywords:	PrioBumpGSS, Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-foreman_maintain-0.8.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1973363 (view as bug list)		Environment:
Last Closed:	2021-11-16 13:48:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kenny Tordeurs 2020-11-16 12:20:23 UTC

Description of problem:
Upgrade can fail when not enough space is available to complete the upgrade to rh-postgresql12-postgresql-server.

/var/lib/pgsql -> /var/opt/rh/rh-postgresql12/lib/pgsql

Version-Release number of selected component (if applicable):
Satellite 6.7 -> Satellite 6.8

How reproducible:
100%

Steps to Reproduce:
1. Have not enough space available under /var/opt/rh/rh-postgresql12/lib/pgsql
2. Try upgrade
3.

Actual results:
No errors or warnings

Expected results:
Warning that not enough space is available before performing the upgrade

Additional info:

Comment 1 Bryan Kearney 2021-04-06 12:10:35 UTC

Upstream bug assigned to aupadhye

Comment 2 Bryan Kearney 2021-05-20 20:04:38 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/32253 has been resolved.

Comment 3 Gaurav Talreja 2021-07-23 19:51:32 UTC

Verified.

Tested on Satellite 6.7.5 with version rubygem-foreman_maintain-0.8.7-1.el7sat.noarch (from Satellite 6.10.0 Snap 10.0)


Setup:
1. Have some data under /var/lib/pgsql (upgrade templates have ~565Mib data)
2. Create dir /var/opt/rh/rh-postgresql12/ and mount a partition of ~300Mib to this dir (less than /var/lib/pgsql)


Steps:
1. # foreman-maintain upgrade check --target-version 6.8
OR 
1. # foreman-maintain health check --label available-space-for-postgresql12


Observations:
This check is only applicable for the pre-upgrade check of 6.7, which shows warnings if /var/opt/rh/rh-postgresql12/ available space is less than consumed space of /var/lib/pgsql, like
--------------------------------------------------------------------------------
Check to make sure PostgreSQL 12 work directory has enough space for upgrade: 
                                                                      [WARNING]
Satellite 6.7 uses PostgreSQL 12. 
This changes PostgreSQL work directory to /var/opt/rh/rh-postgresql12/
The new work directory requires at least 565MiB free space for upgrade!
--------------------------------------------------------------------------------

Comment 6 errata-xmlrpc 2021-11-16 13:48:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.10 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4697