Bug 1898589
| Summary: | Duplicated entries in .ss/authorized_keys from remote_execution_ssh_keys snippet | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Gianfranco Sigrisi <gsigrisi> | ||||
| Component: | Provisioning Templates | Assignee: | satellite6-bugs <satellite6-bugs> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Roman Plevka <rplevka> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 6.8.0 | CC: | ahumbe, mhulan, myllynen, pcfe | ||||
| Target Milestone: | Unspecified | Keywords: | EasyFix, Triaged | ||||
| Target Release: | Unused | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2020-11-20 13:48:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
FWIW: this also happens with 6.7.3 Please provide the value of remote_execution_ssh_keys parameter, if there's no value, how many Capsules with remote execution the customer have (I assume 3)? Note that we deploy all keys from all REX Capsules. We could add unification of that array, that would be a simple fix. Given there's no harm in having duplicates in authorized_keys, I'm lowering the severity. Hi Marek,
here we go:
1 remote execution user with 2 ssh pub keys:
foreman_users:
rex:
firstname: Ansible Remote Execution
lastname: User
mail: ''
description: ''
fullname: Ansible Remote Execution User
name: rex
ssh_authorized_keys:
- type: ssh-ed25519
key: AAAAC3NzaC1lZDI1NTE5AAAAIJD9OFIQFzrPXb7rBOBReH......
comment: rex.com
- type: ssh-rsa
key: AAAAB3NzaC1yc2EAAAADAQABAAABAQDmOHvEA8B99PAc8X......
comment: rex.com
1 key for the foreman-proxy user
remote_execution_ssh_keys:
- ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC7QH/S8sJPExnVtvAdQEurL1.... foreman-proxy.com
1 capsule:
# hammer --output yaml capsule list
---
- Id: 1
Name: satellite.example.com
URL: https://satellite.example.com:9090
Features:
- Logs
- Dynflow
- SSH
- Discovery
- Openscap
- Ansible
- Templates
- Pulp
- TFTP
- Puppet
- DHCP
- HTTPBoot
- Puppet CA
At the moment I added .uniq.join in a cloned snippet for the remote_execution_ssh_keys:
cat << EOF >> <%= ssh_path %>/authorized_keys
<%= host_param('remote_execution_ssh_keys').is_a?(String) ? host_param('remote_execution_ssh_keys') : host_param('remote_execution_ssh_keys').uniq.join("\n") %>
EOF
In this way it forces to remove the duplicated entries but.... there is no need to deduplicate because there is only 1 entry.
Interesting, thanks for the additional data, it seems it may be related to the user keys too. Anyway, adding uniq.join is a good workaround and resolves the issue until it's fixed. Hi Marek, Just to be clear, the duplicated keys that are appended to the file are *only* the ones for the foreman-proxy user. This appears to be a duplicate of bug 1856758; therefore, closing this instance. Please feel free to re-open if it is determined to be different. *** This bug has been marked as a duplicate of bug 1856758 *** |
Created attachment 1730174 [details] .ssh/authorized_keys duplicated entries for remote_execution user Description of problem: The following part of the snippet: remote_execution_ssh_keys: cat << EOF >> <%= ssh_path %>/authorized_keys <%= host_param('remote_execution_ssh_keys').is_a?(String) ? host_param('remote_execution_ssh_keys') : host_param('remote_execution_ssh_keys').join("\n") %> EOF Generates 3 times the entries for the foreman-proxy ssh .pub key in the remote_execution_ssh_user setup. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Render the template and check for the kickstart config file containing the remote_execution_ssh_keys stanza 2. 3. Actual results: Expected results: 1 entry per key Additional info: Attached the output of a kickstart file rendered with the duplicated entries.