Bug 189874

Summary:	Review Request: perl-Test-SubCalls - Track the number of times subs are called
Product:	[Fedora] Fedora	Reporter:	Jose Pedro Oliveira <jose.p.oliveira.oss>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-04-25 16:09:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Jose Pedro Oliveira 2006-04-25 13:45:59 UTC

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-SubCalls.spec

SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-SubCalls-0.05-1.src.rpm

Description:
There are a number of different situations (like testing cacheing
code) where you want to want to do a number of tests, and then verify
that some underlying subroutine deep within the code was called a
specific number of times.

Notes:
1 - Targets: FE5 and devel (due to Test::* version requirements)
2 - Last requirement for http://search.cpan.org/dist/PPI/

Comment 1 Jason Tibbitts 2006-04-25 15:22:18 UTC

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible and included in the package.
* source files match upstream:
   23ae21fea8a30477aba508b4a6f785b5  Test-SubCalls-0.05.tar.gz
   23ae21fea8a30477aba508b4a6f785b5  Test-SubCalls-0.05.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock (development, i386).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Jose Pedro Oliveira 2006-04-25 16:09:48 UTC

Thanks for the review.

Imported and built for FC-5 and devel.

Will try to finish the PPI specfile shortly
(beta: http://gsd.di.uminho.pt/jpo/software/fedora/perl-PPI-1.112-0.src.rpm)