Bug 1898831

Summary:	kcm operator shall pass --allocate-node-cidrs=false to kcm for ovn-kube and openshift-sdn cluster
Product:	OpenShift Container Platform	Reporter:	Peng Liu <pliu>
Component:	kube-controller-manager	Assignee:	Maciej Szulik <maszulik>
Status:	CLOSED ERRATA	QA Contact:	RamaKasturi <knarra>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.6	CC:	aos-bugs, knarra, maszulik, mfojtik, yinzhou
Target Milestone:	---	Keywords:	UpcomingSprint
Target Release:	4.6.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1898159	Environment:
Last Closed:	2020-12-14 13:50:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1898159
Bug Blocks:

Description Peng Liu 2020-11-18 08:18:53 UTC

+++ This bug was initially created as a clone of Bug #1898159 +++

Description of problem:

By default, the kcm-operator pass default configuration to kcm with 'allocate-node-cidrs=true'. With such configuration, the kcm will allocate `podCIDR` in node.spec. However, openshift-sdn and ovn-kubernetes both do their own CIDR allocation. So the `podCIDR` is not utilized by either of them.

Additionally, as we set 'allocate-node-cidrs=false', we shall not pass 'cluster-cidr' and 'service-cluster-ip-range' for kcm either.

Version-Release number of selected component (if applicable):


How reproducible:
Install a cluster with openshift-sdn or ovn-kubernetes as the cluster network provider.

Steps to Reproduce:
1.
2.
3.

Actual results:
$ oc logs -n openshift-kube-controller-manager kube-controller-manager-ip-10-0-160-243.us-west-2.compute.internal
...
I1116 14:42:55.218650       1 flags.go:59] FLAG: --allocate-node-cidrs="true"
...

Expected results:

I1116 14:42:55.218650       1 flags.go:59] FLAG: --allocate-node-cidrs="false"

Additional info:

Comment 1 Maciej Szulik 2020-11-30 12:51:20 UTC

PR is already in the queue.

Comment 2 RamaKasturi 2020-12-01 10:41:26 UTC

Verified in the payload below and i see that  --allocate-node-cidrs is set to "false", have added lgtm in the PR link, will wait for the cluster bot to move the bug to verified state once the PR is merged.

[knarra@knarra openshift-client-linux-4.7.0-0.nightly-2020-11-30-172451]$ oc get clusterversion
NAME      VERSION                                           AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.6.0-0.ci.test-2020-12-01-095103-ci-ln-31q5mx2   True        False         7m7s    Cluster version is 4.6.0-0.ci.test-2020-12-01-095103-ci-ln-31q5mx2

[knarra@knarra openshift-client-linux-4.7.0-0.nightly-2020-11-30-172451]$ oc logs kube-controller-manager-ci-ln-31q5mx2-f76d1-pjrlk-master-0 -n openshift-kube-controller-manager | grep allocate-node-cidrs
I1201 10:26:45.840302       1 flags.go:59] FLAG: --allocate-node-cidrs="false"
[knarra@knarra openshift-client-linux-4.7.0-0.nightly-2020-11-30-172451]$ oc logs kube-controller-manager-ci-ln-31q5mx2-f76d1-pjrlk-master-1 -n openshift-kube-controller-manager | grep allocate-node-cidrs
I1201 10:27:22.171087       1 flags.go:59] FLAG: --allocate-node-cidrs="false"
[knarra@knarra openshift-client-linux-4.7.0-0.nightly-2020-11-30-172451]$ oc logs kube-controller-manager-ci-ln-31q5mx2-f76d1-pjrlk-master-2 -n openshift-kube-controller-manager | grep allocate-node-cidrs
I1201 10:26:07.431866       1 flags.go:59] FLAG: --allocate-node-cidrs="false"
I1201 10:27:21.869379       1 core.go:240] Will not configure cloud provider routes for allocate-node-cidrs: false, configure-cloud-routes: false.

Comment 4 RamaKasturi 2020-12-07 08:50:07 UTC

Moving the bug to verified state as the fix is already present in the payload below and bot has not changed the status.

4.6.0-0.nightly-2020-12-04-142414

Comment 7 errata-xmlrpc 2020-12-14 13:50:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.6.8 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5259