Bug 1898951

Summary:	after finish installation with wizard, close button prompts cleanup tool
Product:	[oVirt] cockpit-ovirt	Reporter:	Aviv Turgeman <aturgema>
Component:	Generic	Assignee:	Aviv Turgeman <aturgema>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Wei Wang <weiwang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	0.14.4	CC:	arachman, bugs, cshao, lsvaty, mavital, mtessun, nlevy, peyu, rcpoling, sbonazzo, shlei, weiwang, yaniwang
Target Milestone:	ovirt-4.4.3-2	Flags:	pm-rhel: ovirt-4.4+ sbonazzo: devel_ack+ weiwang: testing_ack+
Target Release:	0.14.15
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.14.15	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-01-22 12:52:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Aviv Turgeman 2020-11-18 11:29:04 UTC

Description of problem:
When finishing an installation, The wizard prompts a massage to close the wizard.
when click on 'no' it returns to wizard as it should. when click on 'yes' wizard prompts another massage, to start ovirt-hosted-engine-cleanup tool, when click 'no' the dashboard returns to initial state where it can start the deployment again, when click 'yes' cleanup tool delete

Version-Release number of selected component (if applicable):
ovirt-node-ng-installer-4.4.3-2020111016.el8

How reproducible:
100%

Steps to Reproduce:
1. start a cockpit installation and finish it
2. click on close on the bottom right corner of wizard or little 'x' on top right corner of wizard
3. follow 'Description of problem' flow written above.

Actual results:
The worst case scenario is when click on 'yes' to cleanup tool, deleting all installation just made.
The better case scenario when click on 'no' to cleanup tool, and then dashboard returns to initial state where it can start the deployment again.

Expected results:
The Wizard should just be closed, since it is already finished.

Additional info:
when click on 'no' to cleanup tool, the initial dashboaed will disappear if we switch tabs in cockpit dashboard or when refreshing the page.

Comment 1 Aviv Turgeman 2020-11-26 09:25:11 UTC

for some reason, gerrit did not attached patch to bug: https://gerrit.ovirt.org/c/cockpit-ovirt/+/112369
Moving to POST.

Comment 2 Wei Wang 2020-12-11 04:00:40 UTC

Test with RHVH-4.4-20201210.0-RHVH-x86_64-dvd1.iso. 
When clicking on close on the bottom right corner of wizard after hosted engine deployment is finished, it will display "Hosted Engine is running" page directly not the cleanup tool.
QE have no chance to select "yes" or "no".

Comment 3 RHEL Program Management 2020-12-11 04:00:45 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Wei Wang 2020-12-11 05:30:24 UTC

Make mistake. Correct myself.

Test with RHVH-4.4-20201210.0-RHVH-x86_64-dvd1.iso. 
When clicking on close on the bottom right corner of wizard after hosted engine deployment is finished, it will display "Hosted Engine is running" page directly and the Wizard should just be closed.

This bug is fixed, move it to "VERIFIED"