Bug 1898974

Summary: python-pyside2 fails to build with Python 3.10: Py_TYPE= needs to be replaced with Py_SET_TYPE
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-pyside2Assignee: Richard Shaw <hobbes1069>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: hobbes1069, laurent.rineau__fedora, mhroncok, thrnciar, tuju
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-18 19:52:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1890881    

Description Miro Hrončok 2020-11-18 12:23:41 UTC
python-pyside2 fails to build with Python 3.10.0a2.

[  0%] Building CXX object sources/shiboken2/tests/libminimal/CMakeFiles/libminimal.dir/typedef.cpp.o
cd /builddir/build/BUILD/pyside-setup-opensource-src-5.15.1/x86_64-redhat-linux-gnu/sources/shiboken2/tests/libminimal && /usr/bin/clang++ -DLIBMINIMAL_BUILD -Dlibminimal_EXPORTS -I/builddir/build/BUILD/pyside-setup-opensource-src-5.15.1/sources/shiboken2/tests/libminimal -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -m64 -mtune=generic -fasynchronous-unwind-tables -fcf-protection -Wall -fvisibility=hidden -Wno-strict-aliasing -D QT_NO_CAST_FROM_ASCII -D QT_NO_CAST_TO_ASCII -DNDEBUG -fPIC   -fPIC -std=gnu++11 -o CMakeFiles/libminimal.dir/typedef.cpp.o -c /builddir/build/BUILD/pyside-setup-opensource-src-5.15.1/sources/shiboken2/tests/libminimal/typedef.cpp
/builddir/build/BUILD/pyside-setup-opensource-src-5.15.1/sources/shiboken2/libshiboken/basewrapper.cpp:369:23: error: expression is not assignable
        Py_TYPE(type) = SbkObjectType_TypeF();
        ~~~~~~~~~~~~~ ^
/builddir/build/BUILD/pyside-setup-opensource-src-5.15.1/sources/shiboken2/libshiboken/basewrapper.cpp:1104:23: error: expression is not assignable
    Py_TYPE(heaptype) = SbkObjectType_TypeF();
    ~~~~~~~~~~~~~~~~~ ^

Since Py_TYPE() is changed to the inline static function, Py_TYPE(obj) = new_type must be replaced with Py_SET_TYPE(obj, new_type): see Py_SET_TYPE() (available since Python 3.9). For backward compatibility, this macro can be used:

#if PY_VERSION_HEX < 0x030900A4
#  define Py_SET_TYPE(obj, type) ((Py_TYPE(obj) = (type)), (void)0)


For the build logs, see:

For all our attempts to build python-pyside2 with Python 3.10, see:

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Richard Shaw 2020-11-18 12:56:05 UTC
I've sent an email to the upstream mailing list. Do I need to do anything else at this point? We could implement the workaround of course but if they promise to fix it in a point release, is that good enough?

Comment 2 Miro Hrončok 2020-11-18 13:07:47 UTC
See the plan at https://fedoraproject.org/wiki/Changes/Python3.10#Important_dates_and_plan

We anticipate to upgrade in half a year.

Do note however that packages that BR this won't be build/tested until we fix it.

Comment 3 Miro Hrončok 2020-11-18 17:57:17 UTC
The change was reverted in Python 3.10, because it caused too much trouble (the amount of affected Fedora packages was too big). Keeping this open for now, unit  anew alpha version is out to test it out.

This comment is mass posted in all relevant bugzillas. If you already worked upstream to fix the problem, please let them know about the revert.


Comment 4 Miro Hrončok 2020-11-18 19:52:49 UTC
I've patched Python 3.10 in our testing copr to include the revert. Sorry for the noise.

Building pyside2 again. It is past this failure. If there is a new one, I'll report.