Bug 1899743

Summary: OCS podDisruptionBudget prevents successful OCP upgrades
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Travis Nielsen <tnielsen>
Component: rookAssignee: Santosh Pillai <sapillai>
Status: CLOSED ERRATA QA Contact: Shrivaibavi Raghaventhiran <sraghave>
Severity: high Docs Contact:
Priority: high    
Version: 4.6CC: aclewett, alchan, assingh, bengland, bkunal, cblum, dahernan, dkochuka, dmoessne, dyocum, ebenahar, etamir, jhopper, laparici, lars, madam, mgugino, muagarwa, mwasher, nberry, nelluri, ocs-bugs, owasserm, ratamir, rcyriac, r.martinez, rojoseph, sapillai, shan, sraghave, tdesala, tnielsen, wking, ykaul
Target Milestone: ---Keywords: Upgrades, ZStream
Target Release: OCS 4.6.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 1861104 Environment:
Last Closed: 2021-02-01 13:18:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1861104, 1915851, 1916585    
Bug Blocks:    

Comment 1 Travis Nielsen 2020-11-19 21:42:02 UTC
The PDBs have been a recurring pain point with the previous implementation so we should backport to 4.6.z

Comment 9 Travis Nielsen 2020-12-08 20:50:54 UTC
While there has been thorough testing (upstream 1.5.1 release, Santosh, myself, Annette, and a couple others), I do see it would be better to hold off until the z stream. If there is any regression with this design change, it would put the GA release at risk to move to next year. In other words, I would rather not risk requiring yet another RC before GA if this has a regression.

@Mudit @Elad Thoughts?

Comment 17 Travis Nielsen 2021-01-15 17:36:48 UTC
https://github.com/openshift/rook/pull/152 has been merged!

Comment 19 Santosh Pillai 2021-01-25 05:00:04 UTC
cancelling needInfo for doc text.

Comment 21 Shrivaibavi Raghaventhiran 2021-01-29 14:23:51 UTC
Performed the Upgrades Test on VMWARE dynamic and AWS platforms
****************************************************************

Initial and Upgraded Tested Configurations
******************************************

*
Initial config - VMware
3M and 3W
OCP 4.6-ga, OCS 4.6.2

Upgraded to
OCP 4.7.0-fc.4

*
Initial config - VMware
3M and 3W
OCP 4.6-ga, OCS ocs-operator.v4.6.1

Upgraded to
OCP 4.7.0-fc.4, OCS ocs-operator.v4.6.2-233.ci

*
Initial config - AWS
3M and 6W
OCP 4.6-ga, OCS ocs-operator.v4.6.1

Upgraded to
OCP 4.7.0-fc.4, OCS ocs-operator.v4.6.2-233.ci

Validations
************
1. Successful upgrades of OCP and OCS
2. Versions lesser than ocs-operator.v4.6.2-233.ci have PDBs for each osds like rook-ceph-osd-0, rook-ceph-osd-1, rook-ceph-osd-2
3. Versions greater than or equal to ocs-operator.v4.6.2-233.ci have PDBs collectively for osds like rook-ceph-osd
4. Rook-ceph-drain-canary pods disappeared after upgrade of OCS version to ocs-operator.v4.6.2-233.ci


All the above validations passed and hence moving the BZ to Verified state.

Comment 25 errata-xmlrpc 2021-02-01 13:18:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.6.2 container bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0305

Comment 26 Elad 2021-02-10 07:52:48 UTC
Clearing needinfo as the bug was already fixed in 4.6.z