Bug 1899776

Summary:	Review Request: python-volatile - A small extension for the tempfile module
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-29 01:14:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1899777, 1899779

Description Michel Lind 2020-11-20 00:22:17 UTC

Spec URL: https://salimma.fedorapeople.org/specs/python/python-volatile.spec
SRPM URL: https://salimma.fedorapeople.org/specs/python/python-volatile-2.1.0-1.fc33.src.rpm
Description:
Temporary files and directories.

Contains replacement for tempfile.NamedTemporaryFile that does not delete the
file on close(), but still unlinks it after the context manager ends, as well as
a mkdtemp-based temporary directory implementation.

- Mostly reuses the stdlib implementations, supporting the same signatures.
- Due to that, uses the OS’s built-in temporary file facilities, no custom
  schemes.
- Tested on Python 2.6+ and 3.3+

Fedora Account System Username: salimma

Comment 1 Neal Gompa 2020-11-20 00:41:19 UTC

Review notes:

* Package is properly named per Packaging Guidelines
* Package builds and installs correctly
* Packaging follows Python Packaging Guidelines
* Package does not include a license file

Michel, could you switch to just pulling the release from GitHub instead of PyPI? That way, you'd have a license file. Alternatively, you can do something like what python-trololio does to get the license file included[1].

[1]: https://src.fedoraproject.org/rpms/python-trololio/blob/master/f/python-trololio.spec#_29-30

Comment 2 Michel Lind 2020-11-20 02:07:58 UTC

yeah, let me try doing that.

Comment 3 Michel Lind 2020-11-20 02:13:11 UTC

Spec URL: https://salimma.fedorapeople.org/specs/python/python-volatile.spec
SRPM URL: https://salimma.fedorapeople.org/specs/python/python-volatile-2.1.0-2.fc33.src.rpm

using GitHub source tarball, which includes the license text

Comment 4 Neal Gompa 2020-11-20 02:14:43 UTC

Looks good to me!

PACKAGE APPROVED.

Comment 5 Michel Lind 2020-11-20 02:18:58 UTC

Thanks!

❯ fedpkg request-repo python-volatile 1899776                                                
https://pagure.io/releng/fedora-scm-requests/issue/30819

Comment 6 Gwyn Ciesla 2020-11-20 14:16:26 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-volatile

Comment 7 Fedora Update System 2020-11-20 22:46:49 UTC

FEDORA-2020-8824979bf1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1

Comment 8 Fedora Update System 2020-11-21 02:43:57 UTC

FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8824979bf1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-11-21 02:46:23 UTC

FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-96fc0244e0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-96fc0244e0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-11-29 01:14:03 UTC

FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-11-29 01:25:19 UTC

FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.