Bug 1899777

Summary:	Review Request: python-moreorless - Python diff wrapper
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-29 01:14:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1899776
Bug Blocks:	1899779

Description Michel Lind 2020-11-20 00:23:44 UTC

Spec URL: https://salimma.fedorapeople.org/specs/python/python-moreorless.spec
SRPM URL: https://salimma.fedorapeople.org/specs/python/python-moreorless-0.3.0-1.fc33.src.rpm
Description:
This is a thin wrapper around difflib.unified_diff that Does The Right Thing for
"No newline at eof". The args are also simplified compared to difflib.

Fedora Account System Username: salimma

Comment 1 Neal Gompa 2020-11-20 00:43:10 UTC

Review notes:

* Package is properly named per Packaging Guidelines
* Package builds and installs correctly
* Packaging follows Python Packaging Guidelines
* Package licensing is marked correctly and license file is correctly installed

PACKAGE APPROVED.

Comment 2 Michel Lind 2020-11-20 02:07:00 UTC

Thanks!

❯ fedpkg request-repo python-moreorless 1899777       
https://pagure.io/releng/fedora-scm-requests/issue/30818

Comment 3 Gwyn Ciesla 2020-11-20 14:16:05 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-moreorless

Comment 4 Fedora Update System 2020-11-20 22:46:52 UTC

FEDORA-2020-8824979bf1 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1

Comment 5 Fedora Update System 2020-11-20 22:46:59 UTC

FEDORA-2020-96fc0244e0 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-96fc0244e0

Comment 6 Fedora Update System 2020-11-21 02:43:59 UTC

FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8824979bf1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8824979bf1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-11-21 02:46:25 UTC

FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-96fc0244e0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-96fc0244e0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-11-29 01:14:07 UTC

FEDORA-2020-96fc0244e0 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-11-29 01:25:21 UTC

FEDORA-2020-8824979bf1 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.