Bug 1899888

Summary: Undefined behaviour when getting address in do_basic_transform leads to crash
Product: [Fedora] Fedora Reporter: Sebastien Gonzalve <sebastien.gonzalve>
Component: boostAssignee: Jonathan Wakely <jwakely>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 32CC: dakingun, denis.arnaud_fedora, jwakely
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: boost-1.73.0-10.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-11 23:37:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch for the rpm generation until upstream fixes it. none

Description Sebastien Gonzalve 2020-11-20 10:23:55 UTC 
Description of problem:
full detail is in https://github.com/boostorg/locale/issues/52
originally seem on performous project https://github.com/performous/performous/issues/476 

Version-Release number of selected component (if applicable):
boost-locale 1.69.0 has it

How reproducible:
I wasn't able to produce it outside the performous build, mainly because is is triggered thru std::regex library and I don't really master the boilerplate in there.
That said, running performous configured to compile against std::regex does systematically crashes on startup.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Sebastien Gonzalve 2020-11-20 10:25:32 UTC 
I submitted a patch to the boost project (see https://github.com/boostorg/locale/issues/52), and I would like to propose you a patch on the rpm generation as well until it get merges upstream as it may crash in any application.

Seems this happends mainly on RH-based distro as some assert() in the STL are enabled on RH, and seem to be deisable on debian-based distros.

Patch was generated over https://src.fedoraproject.org/rpms/boost.git rev: 820bf321370d25d29274339e01501f287eab35ba

I attach the patch to the bug
Comment 2 Sebastien Gonzalve 2020-11-20 10:27:21 UTC 
Created attachment 1731214 [details]
patch for the rpm generation until upstream fixes it.
Comment 3 Jonathan Wakely 2020-11-20 10:30:32 UTC 
Thanks for the report and the patch.
Comment 4 Jonathan Wakely 2020-11-20 10:31:16 UTC 
(In reply to Sebastien Gonzalve from comment #1)
> Seems this happends mainly on RH-based distro as some assert() in the STL
> are enabled on RH, and seem to be deisable on debian-based distros.

That's right, we build the distro with -D_GLIBCXX_ASSERTIONS enabled.
Comment 5 Fedora Update System 2021-03-03 13:53:06 UTC 
FEDORA-2021-6148d9a01f has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6148d9a01f
Comment 6 Jonathan Wakely 2021-03-03 13:54:39 UTC 
This has been fixed in rawhide for some time, but I forgot to push the patch for the stable releases. There's an update for F33 now. If that fixes the problem for performous I'll also update F32.
Comment 7 Fedora Update System 2021-03-03 23:52:43 UTC 
FEDORA-2021-6148d9a01f has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6148d9a01f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6148d9a01f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2021-03-11 23:37:02 UTC 
FEDORA-2021-6148d9a01f has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 9 Sebastien Gonzalve 2021-03-12 18:51:33 UTC 
Thank you for the fix, I did not have time to rebuild the package for my fedora32 and perform the tests, I'll let you know when I'm done.
Comment 10 Jonathan Wakely 2021-03-12 21:50:05 UTC 
There is a scratch build for F32 underway at https://koji.fedoraproject.org/koji/taskinfo?taskID=63666370

When that finishes you'll be able to download packages from there to test with.
Comment 11 Sebastien Gonzalve 2021-03-13 11:36:44 UTC 
Tested your packages on fedora 32 with the original setup (performous). I confirm that the bug cannot be reproduced anymore.
Thank you for the merge, may you publish packages for fedora 32 updates?
Comment 12 Fedora Update System 2021-03-15 11:43:48 UTC 
FEDORA-2021-5f94a30af2 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5f94a30af2
Comment 13 Fedora Update System 2021-03-15 19:42:49 UTC 
FEDORA-2021-5f94a30af2 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-5f94a30af2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-5f94a30af2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 14 Fedora Update System 2021-03-23 01:11:39 UTC 
FEDORA-2021-5f94a30af2 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 15 Sebastien Gonzalve 2021-03-24 18:55:53 UTC 
Updated may local build with the FC32 updates (boost-regex-1.69.0-19.fc32.x86_64)
I confirm that there is no crash anymore with official update packages.

Thank you :)