Bug 1900147

Taking this review.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "*No copyright*
     Apache License 2.0", "Expat License", "GNU General Public License,
     Version 2". 137 files have unknown license. Detailed output of
     licensecheck in /home/ngompa/1900147-fb303/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
     present.
     Note: Package has .a files: fb303-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: fb303-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
          fb303-devel-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
          fb303-static-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
          fb303-debuginfo-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
          fb303-debugsource-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
          fb303-0-0.1.20201116git4058b7e.fc34.src.rpm
fb303.x86_64: W: no-version-in-last-changelog
fb303-devel.x86_64: W: no-version-in-last-changelog
fb303-static.x86_64: W: no-version-in-last-changelog
fb303-static.x86_64: W: no-documentation
fb303-debuginfo.x86_64: W: no-version-in-last-changelog
fb303-debugsource.x86_64: W: no-version-in-last-changelog
fb303.src: W: no-version-in-last-changelog
fb303.src: E: specfile-error Packaging variables read or set by %forgemeta
fb303.src: E: specfile-error   forgeurl:          https://github.com/facebook/fb303
fb303.src: E: specfile-error   forgesource:       https://github.com/facebook/fb303/archive/4058b7ec140b64c5f666ce3f967aa5dae6587ce0/fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0.tar.gz
fb303.src: E: specfile-error   forgesetupargs:    -n fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0
fb303.src: E: specfile-error   archivename:       fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0
fb303.src: E: specfile-error   archiveext:        tar.gz
fb303.src: E: specfile-error   archiveurl:        https://github.com/facebook/fb303/archive/4058b7ec140b64c5f666ce3f967aa5dae6587ce0/fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0.tar.gz
fb303.src: E: specfile-error   topdir:            fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0
fb303.src: E: specfile-error   extractdir:        fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0
fb303.src: E: specfile-error   repo:              fb303
fb303.src: E: specfile-error   scm:               git
fb303.src: E: specfile-error   commit:            4058b7ec140b64c5f666ce3f967aa5dae6587ce0
fb303.src: E: specfile-error   date:              20201116
fb303.src: E: specfile-error   distprefix:        .20201116git4058b7e
fb303.src: E: specfile-error   dist:              .20201116git4058b7e.fc33
fb303.src: E: specfile-error   (snapshot date is either manually supplied or computed once %{_sourcedir}/%{archivename}.%{archiveext} is available)
6 packages and 0 specfiles checked; 16 errors, 7 warnings.




Rpmlint (debuginfo)
-------------------
Checking: fb303-debuginfo-0-0.1.20201116git4058b7e.fc34.x86_64.rpm
fb303-debuginfo.x86_64: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 0 errors, 1 warnings.





Rpmlint (installed packages)
----------------------------
fb303-debugsource.x86_64: W: no-version-in-last-changelog
fb303-debuginfo.x86_64: W: no-version-in-last-changelog
fb303-static.x86_64: W: no-version-in-last-changelog
fb303-static.x86_64: W: no-documentation
fb303-devel.x86_64: W: no-version-in-last-changelog
fb303.x86_64: W: no-version-in-last-changelog
fb303.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfb303.so.0.20201116 /lib64/libconcurrency.so.2020.11.16.0
fb303.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfb303.so.0.20201116 /lib64/libcrypto.so.1.1
fb303.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfb303_thrift_cpp.so.0.20201116 /lib64/libconcurrency.so.2020.11.16.0
fb303.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libfb303_thrift_cpp.so.0.20201116 /lib64/libcrypto.so.1.1
5 packages and 0 specfiles checked; 0 errors, 10 warnings.



Source checksums
----------------
https://github.com/facebook/fb303/archive/4058b7ec140b64c5f666ce3f967aa5dae6587ce0/fb303-4058b7ec140b64c5f666ce3f967aa5dae6587ce0.tar.gz :
  CHECKSUM(SHA256) this package     : 37a70982fd75ad874efc8ff2affc1f3c10ae7c1e8433338edd39c5e376dc7c95
  CHECKSUM(SHA256) upstream package : 37a70982fd75ad874efc8ff2affc1f3c10ae7c1e8433338edd39c5e376dc7c95


Requires
--------
fb303 (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libasync.so.2020.11.16.0()(64bit)
    libboost_regex.so.1.73.0()(64bit)
    libc.so.6()(64bit)
    libconcurrency.so.2020.11.16.0()(64bit)
    libcrypto.so.1.1()(64bit)
    libfb303_thrift_cpp.so.0.20201116()(64bit)
    libfmt.so.7()(64bit)
    libfolly.so.2020.11.16.00()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgflags.so.2.2()(64bit)
    libglog.so.0()(64bit)
    libpthread.so.0()(64bit)
    librpcmetadata.so.2020.11.16.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libthriftcpp2.so.2020.11.16.0()(64bit)
    libthriftmetadata.so.2020.11.16.0()(64bit)
    libthriftprotocol.so.2020.11.16.0()(64bit)
    libtransport.so.2020.11.16.0()(64bit)
    rtld(GNU_HASH)

fb303-devel (rpmlib, GLIBC filtered):
    cmake-filesystem
    cmake-filesystem(x86-64)
    fb303(x86-64)
    libfb303.so.0.20201116()(64bit)
    libfb303_thrift_cpp.so.0.20201116()(64bit)

fb303-static (rpmlib, GLIBC filtered):
    cmake-filesystem(x86-64)
    fb303-devel(x86-64)

fb303-debuginfo (rpmlib, GLIBC filtered):

fb303-debugsource (rpmlib, GLIBC filtered):



Provides
--------
fb303:
    fb303
    fb303(x86-64)
    libfb303.so.0.20201116()(64bit)
    libfb303_thrift_cpp.so.0.20201116()(64bit)

fb303-devel:
    cmake(fb303)
    fb303-devel
    fb303-devel(x86-64)

fb303-static:
    cmake(fb303)
    fb303-static
    fb303-static(x86-64)

fb303-debuginfo:
    debuginfo(build-id)
    fb303-debuginfo
    fb303-debuginfo(x86-64)

fb303-debugsource:
    fb303-debugsource
    fb303-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1900147 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: PHP, R, Perl, Java, fonts, Python, Ocaml, SugarActivity, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Ignoring the clearly broken parsing of the forge macros, this package looks generally fine.

Please fix the changelog section to have a filled out changelog entry on import.

PACKAGE APPROVED.

Thanks!

❯ fedpkg request-repo fb303 1900147                                                                              
https://pagure.io/releng/fedora-scm-requests/issue/30841

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/fb303

FEDORA-2020-5921980912 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5921980912

FEDORA-2020-53c640d73d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-53c640d73d

FEDORA-2020-5921980912 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5921980912 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5921980912

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-53c640d73d has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-53c640d73d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-53c640d73d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-5921980912 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2020-53c640d73d has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.