Bug 190027

You're missing a buildreq on liblo-devel. And hexter can build against gtk2,
changing the buildreq to gtk2-devel is probably preferable.

rpmlint comes up clean.

All those Requires: can be nuked, rely on auto deps.

However:

$ rpm -qf /usr/lib/dssi/
file /usr/lib/dssi is not owned by any package

dssi seems to be implemented as only a header file. No library. So there's no
library dep to pick up on. All dssi plugins are probably going to have to have
Requires: dssi.

You might want to symlink /usr/bin/hexter to /usr/bin/jack-dssi-host.

Or actually, dssi-devel should probably be pulling in liblo-devel. And ladspa,
jack, and alsa...

Thanks for the comments.  Updated bits here:

Spec URL: http://people.redhat.com/green/FE/FC5/hexter-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/hexter-dssi-0.5.9-2.src.rpm

Looks like the link line needs to be:

ln -s jack-dssi-host $RPM_BUILD_ROOT%{_bindir}/hexter

Otherwise rpmlint complains about it being a non-relative link.

Also, since we're linking it to jack-dssi-host, I'm thinking hexter (and all
other dssi plugins) should have a .desktop link.

(In reply to comment #4)
> Looks like the link line needs to be:
> 
> ln -s jack-dssi-host $RPM_BUILD_ROOT%{_bindir}/hexter
> 
> Otherwise rpmlint complains about it being a non-relative link.

Ok, updates here...

Spec URL: http://people.redhat.com/green/FE/FC5/hexter-dssi.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/hexter-dssi-0.5.9-3.src.rpm

> Also, since we're linking it to jack-dssi-host, I'm thinking hexter (and all
> other dssi plugins) should have a .desktop link.

As discussed on IRC, we've decided to not do this for now.

Alright, I finally blew most of a day figuring out why qjackctl was hanging my
machines, maybe now I can finish this review. :) (kernel-2.6.17-1.2145_FC5 seems
to work so far)

For those watching at home, jack-dssi-host is not a GUI app. We can't give
hexter an icon because trying to start it without jackd running results in a
silent failure.

MUST items:

- rpmlint: Ok

$ rpmlint hexter-dssi-0.5.9-3.fc5.i386.rpm
W: hexter-dssi dangling-relative-symlink /usr/bin/hexter jack-dssi-host

Supplied by dssi.

- Package name: Ok
- Spec name: Ok
- Meets packaging guidelines: NEEDSWORK
- License: Ok
- Spec in American English: Ok
- Spec legible: Ok
- Sources match upstream: Ok
- Builds: Ok
- BuildRequires: Ok
- Locales: Ok
- ldconfig: Ok
- Relocation: Ok
- Directory ownership: Ok
- %files: Ok
- %clean: Ok
- Macros: Ok
- Code vs. Content: Ok
- Documentation: Ok
- devel package: Ok
- .desktop file: Ok

SHOULD:

- Includes license text: Ok
- Mock build: Ok
- Builds on all archs: Built on i386, x86_64
- Package functional: Tested on i386, x86_64
- Scriptlets: Ok
- Subpackages: Ok

NEEDSWORK:

Source URL needs to be [...]sourceforge/dssi/[...]

Don't use %makeinstall, apparently its horribly broken. (This was news to me too)

Non-blockers:

Summary could perhaps mention it's a DX7 clone. "DX7 compatible software
synthesizer plugin" or something. Also tomboy just revealed "compatible" is
spelled wrong, heh...

Put a trailing slash on "%{_datadir}/hexter" in the %files list.

Fix the two NEEDWORK before import, and this is APPROVED.

Now if you could review Rosegarden for me I'd appreciate it. :)

(In reply to comment #6)
> Fix the two NEEDWORK before import, and this is APPROVED.

Fixed - thanks!

> Now if you could review Rosegarden for me I'd appreciate it. :)

Done (kind of).