Bug 1900335
Summary: | Memory leak in git-fast-import | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Villy Kruse <ppywlkiqletw> |
Component: | git | Assignee: | Todd Zullinger <tmz> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 33 | CC: | amahdal, besser82, chrisw, johannes, opohorel, pcahyna, pstodulk, sebastian.kisela, tmz |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | git-2.29.2-3.fc33 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-12-08 01:47:34 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Villy Kruse
2020-11-22 11:13:51 UTC
Hi Villy, Thanks for the report and the link to the upstream patch. I'll get that into the git-2.29.2 update I plan to submit to f33 soon. If you're interested in testing that sooner, I've got a build containing the patch in my COPR: https://copr.fedorainfracloud.org/coprs/tmz/git/ I tested it and the clone of nss succeeded without fast-import using much memory at all. I also noticed that git-remote-hg pulls in git rather than git-core, which seems unnecessary. I may submit a PR to change that, but if you or anyone else who uses git-remote-hg would like to beat me to it, that would be great. It looks like the git-remote-hg package is a few revisions behind upstream, but I didn't want to dig too deeply. (In reply to Todd Zullinger from comment #1) > Hi Villy, > > Thanks for the report and the link to the upstream patch. I'll get that > into the git-2.29.2 update I plan to submit to f33 soon. And to rawhide as well, perhaps. > > If you're interested in testing that sooner, I've got a build containing the > patch in my COPR: > > https://copr.fedorainfracloud.org/coprs/tmz/git/ > > I tested it and the clone of nss succeeded without fast-import using much > memory at all. I already did a build of git-2.29 with the patch and tested it. > > I also noticed that git-remote-hg pulls in git rather than git-core, which > seems unnecessary. I may submit a PR to change that, but if you or anyone > else who uses git-remote-hg would like to beat me to it, that would be > great. It looks like the git-remote-hg package is a few revisions behind > upstream, but I didn't want to dig too deeply. Supposedly, git-remote-hg from https://github.com/mnauw/git-remote-hg.git is python3 ready. (In reply to Villy Kruse from comment #2) > (In reply to Todd Zullinger from comment #1) > > Hi Villy, > > > > Thanks for the report and the link to the upstream patch. I'll get that > > into the git-2.29.2 update I plan to submit to f33 soon. > > And to rawhide as well, perhaps. Of course. It'll always go to rawhide first. :) > Supposedly, git-remote-hg from https://github.com/mnauw/git-remote-hg.git is > python3 ready. That's good to know. As you probably know (but for others who might not), that is the upstream source of the Fedora packages these days. It'd be great if someone who uses that package got it switched over to python3. (In reply to Todd Zullinger from comment #3) > That's good to know. As you probably know (but for others who might not), > that is the upstream source of the Fedora packages these days. It'd be > great if someone who uses that package got it switched over to python3. It should be there anytime now: https://src.fedoraproject.org/rpms/git-remote-hg/pull-request/3 Excellent. I rebased my tiny `s/git/git-core/` change on top of PR#3 and submitted it as https://src.fedoraproject.org/rpms/git-remote-hg/pull-request/4 for comment. FEDORA-2020-5476485ad2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5476485ad2 FEDORA-2020-5476485ad2 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-5476485ad2` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5476485ad2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-5476485ad2 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |