Bug 190090
Summary: | Review Request: ocrad | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Krzysztof Kosz <krzyko> |
Component: | Package Review | Assignee: | Ed Hill <ed> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-31 18:18:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Krzysztof Kosz
2006-04-27 13:55:04 UTC
Hi Krzysztof, here are a few items. Its not a complete review, its just what I could look at in the free time I had today: good: + source matches upstream + license is OK + no warnings or errors from rpmlint + no *.la files + no shared libs + appears to have propoer handling of info files needswork: - the license file should be included in %doc - the INSTALL file should not be in %doc - unfortunately, the buildsystem (configure && make) for ocrad is very minimal (its not based upon the Gnu autotools) and does not honor ${RPM_OPT_FLAGS}. Please patch Makefile.in so that you can use something like: export CXXFLAGS="$RPM_OPT_FLAGS" make in the spec-file Oh, I meant to ask that you please create an SRPM that fixes the above items and I'll then do a full review. So, it's been almost a full year since the last comment on this ticket. Is anything happening here? I will close this ticket soon if there is no response from the submitter. I will close this bug if no response is received within a week from comment 3 (i.e. by 5/31) Closing as NOTABUG. Please file a new review request if someone wants to repackage this software. Thank you! |