Bug 190090

Summary: Review Request: ocrad
Product: [Fedora] Fedora Reporter: Krzysztof Kosz <krzyko>
Component: Package ReviewAssignee: Ed Hill <ed>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-05-31 14:18:47 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Krzysztof Kosz 2006-04-27 09:55:04 EDT
Spec URL: <http://www.clu.cl.opoka.org.pl/test/ocrad.spec>
SRPM URL: <http://www.clu.cl.opoka.org.pl/test/ocrad-0.15-1.src.rpm>
Description: <GNU Ocrad - Optical Character Recognition program.  Reads pnm file(s), or standard input, and sends text to standard output. Kooka (part of the kdegraphics package) can run Ocrad on the scanned image producing text from the scanned image, it also allows to run spellchecker (aspell) on the scanned text highlighting misrecognized words on the image. Recognition results are very promising, with addition of this package Fedora gains functionality to perform optical character recognition. Attached screenshot from recognition process: http://www.clu.cl.opoka.org.pl/test/kooka-ocrad.png>
Comment 1 Ed Hill 2006-05-28 15:34:15 EDT
Hi Krzysztof, here are a few items.  Its not a complete review, its just 
what I could look at in the free time I had today:

 + source matches upstream
 + license is OK 
 + no warnings or errors from rpmlint
 + no *.la files
 + no shared libs
 + appears to have propoer handling of info files

 - the license file should be included in %doc
 - the INSTALL file should not be in %doc
 - unfortunately, the buildsystem (configure && make) for ocrad is 
     very minimal (its not based upon the Gnu autotools) and does 
     not honor ${RPM_OPT_FLAGS}.  Please patch Makefile.in so that 
     you can use something like:

        export CXXFLAGS="$RPM_OPT_FLAGS"

     in the spec-file
Comment 2 Ed Hill 2006-05-28 15:37:16 EDT
Oh, I meant to ask that you please create an SRPM that fixes the above 
items and I'll then do a full review.
Comment 3 Jason Tibbitts 2007-05-24 17:20:39 EDT
So, it's been almost a full year since the last comment on this ticket.  Is
anything happening here?  I will close this ticket soon if there is no response
from the submitter.
Comment 4 Mamoru TASAKA 2007-05-28 09:59:37 EDT
I will close this bug if no response is received within
a week from comment 3 (i.e. by 5/31)
Comment 5 Mamoru TASAKA 2007-05-31 14:18:47 EDT
Closing as NOTABUG.

Please file a new review request if someone wants to
repackage this software. Thank you!