Bug 1901077

Summary:	papi bundles non-free iozone code (version 3.398)
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	papi	Assignee:	William Cohen <wcohen>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bcotton, lberk, wcohen
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	papi-6.0.0-5.fc34 papi-6.0.0-5.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-26 01:36:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	182235

Description Dominik 'Rathann' Mierzejewski 2020-11-24 12:58:45 UTC

Description of problem:
Non-free iozone source code is bundled with papi. iozone license forbids distribution of modified sources and its license was found not permissible for inclusion in Fedora, see https://src.fedoraproject.org/rpms/iozone/blob/master/f/dead.package . The bundled sources are slightly modified (missing CVS $Revision: $ keyword expansion and some printf format strings).

Version-Release number of selected component (if applicable):
papi-6.0.0-4.fc34

How reproducible:
Always.

Steps to Reproduce:
1. fedpkg clone rpms/papi
2. cd papi
3. fedpkg prep
4. ls -1 papi-6.0.0/src/components/appio/tests/iozone/

Actual results:
Changes.txt
client_list
fileop.c
Generate_Graphs
gengnuplot.sh
gnu3d.dem
gnuplot.dem
gnuplotps.dem
Gnuplot.txt
iozone.c
iozone_visualizer.pl
libasync.c
libbif.c
makefile
pit_server.c
read_telemetry
report.pl
spec.in
write_telemetry

Expected results:
ls: cannot access 'papi-6.0.0/src/components/appio/tests/iozone': No such file or directory

Additional info:
The iozone sources should be removed from distributed. It appears they are not used during build, so it should be pretty simple.

Comment 1 Ben Cotton 2020-11-24 13:29:02 UTC

Thank you, Dominik. William if you have questions or need help, please reach out.

Comment 2 William Cohen 2020-11-30 18:53:23 UTC

I have made a pull request to the upstream papi developers to remove the problem iozone code:

https://bitbucket.org/icl/papi/pull-requests/151/wcohen-noiozone/diff

The first patch in the pull request applies cleanly to the existing fedora papi srpm and will remove the iozone source code.  The second patch applies to a README.md file that is not in the papi-6.0.0.

Comment 3 William Cohen 2020-12-17 17:10:10 UTC

The patch was accepted upstream and has been backported to papi-6.0.0-5.fc34.  Also merged the changes into fc33.

Comment 4 Fedora Update System 2020-12-17 17:14:08 UTC

FEDORA-2020-b7db33f005 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b7db33f005

Comment 5 Fedora Update System 2020-12-18 01:14:59 UTC

FEDORA-2020-b7db33f005 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b7db33f005`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b7db33f005

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-12-26 01:36:57 UTC

FEDORA-2020-b7db33f005 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.