Bug 1901395

Summary:	"Edit virtual machine template" action link should be removed
Product:	OpenShift Container Platform	Reporter:	Guohua Ouyang <gouyang>
Component:	Console Kubevirt Plugin	Assignee:	Matan Schatzman <mschatzm>
Status:	CLOSED ERRATA	QA Contact:	Guohua Ouyang <gouyang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.7	CC:	aos-bugs, gouyang, oramraz, rawagner, tjelinek, yzamir
Target Milestone:	---
Target Release:	4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-24 15:35:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Guohua Ouyang 2020-11-25 02:15:14 UTC

Description of problem:
"Edit virtual machine template" still available for user created template
, click it leads to 404 error.

Version-Release number of selected component (if applicable):
master

How reproducible:


Steps to Reproduce:
1. Create a template
2. Click "Edit virtual machine template" in the actions.
3.

Actual results:
"Edit virtual machine template" available.

Expected results:
"Edit virtual machine template" is not available.

Additional info:

Comment 1 Yaacov Zamir 2020-11-29 12:23:19 UTC

@ Rastislav Hi

> Actual results:
> "Edit virtual machine template" available.

> Expected results:
> "Edit virtual machine template" is not available.

AFAIU we should be able to edit custom templates,

Do you know if we should be abale to edit custom templates ?

Comment 2 Rastislav Wagner 2020-11-30 08:35:31 UTC

Expected result is: Link for editing is present for user templates and links to vm template details page

Comment 3 Yaacov Zamir 2020-11-30 09:18:08 UTC

Guohua hi,

I changed the bug title according to answer in https://bugzilla.redhat.com/show_bug.cgi?id=1901395#c2

We should also change the "Expected result" to be "links to vm template details page currectly" instead of "not available"

Comment 5 Guohua Ouyang 2020-12-01 01:16:52 UTC

(In reply to Yaacov Zamir from comment #3)
> Guohua hi,
> 
> I changed the bug title according to answer in
> https://bugzilla.redhat.com/show_bug.cgi?id=1901395#c2
> 
> We should also change the "Expected result" to be "links to vm template
> details page currectly" instead of "not available"

Fine.

Comment 6 Guohua Ouyang 2020-12-01 01:59:51 UTC

Edit the template links to the YAML page, not the details page.

Comment 7 Rastislav Wagner 2020-12-01 11:33:11 UTC

@gouyang Sorry for confusion - i meant YAML tab within details page. Thats where we linked in all previous releases too. Current implementation is fine.

Comment 8 Matan Schatzman 2020-12-01 14:26:16 UTC

We had a discussion with @rawagner , @tjelinek and matt carlton and decided that the links to edit template will be removed.

Comment 12 errata-xmlrpc 2021-02-24 15:35:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633