Bug 1902057

Summary:	Backport patches fixing vhost-vsock-pci command-line regressions to 5.1 release
Product:	[Fedora] Fedora	Reporter:	Christophe de Dinechin <dinechin>
Component:	qemu	Assignee:	Fedora Virtualization Maintainers <virt-maint>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	33	CC:	berrange, cfergeau, cohuck, fidencio, itamar, ondrejj, pbonzini, philmd, rjones, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-5.1.0-8.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-10 01:15:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christophe de Dinechin 2020-11-26 16:49:50 UTC

Description of problem:

The current release of qemu on Fedora 33 has a command-line regression that causes an error with other components, notably kata-runtime.


Version-Release number of selected component (if applicable): qemu-5.1.0-5.fc33.x86_64, kata-runtime-1.11.1-1.fc33.1.x86_64


How reproducible: Always


Steps to Reproduce:
1. Install the components above, as well as podman (for convenience)
2. Run `podman -it --rm --runtime=/usr/bin/kata-runtime ubi8 bash

Actual results:

qemu fails to start and complains about a command-line option:

Error: failed to launch qemu: exit status 1, error messages from qemu log: qemu-system-x86_64: -device vhost-vsock-pci,disable-modern=false,vhostfd=3,id=vsock-902243561,guest-cid=902243561,romfile=: device is modern-only, use disable-legacy=on: OCI runtime error


Expected results:

Container starts


Additional info:

Tracked upstream on the kata-containers side: https://github.com/kata-containers/runtime/issues/3090.

Patches to apply available here: https://github.com/kata-containers/kata-containers/commit/154a356ad43319f5f2a917d6742db735ac3610a5 (also contains a pointer to the relevant email threads)

Comment 1 Fabiano Fidêncio 2020-11-26 17:13:16 UTC

I've spoken with Cornelia and with Cole as I hit this issue on virt-preview repo.
Cornelia's suggestion of what should be backported is: `620907050398 ("vhost-vsock-pci: force virtio version 1") and its friends`.

Comment 2 Cornelia Huck 2020-11-26 17:19:23 UTC

For reference, the 'friends' I referred to are all in this patchset: https://lore.kernel.org/qemu-devel/20200921122506.82515-1-sgarzare@redhat.com/

Comment 3 Fedora Update System 2020-12-03 23:47:51 UTC

FEDORA-2020-9e922bc3a5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9e922bc3a5

Comment 4 Fedora Update System 2020-12-05 01:59:24 UTC

FEDORA-2020-9e922bc3a5 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-9e922bc3a5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9e922bc3a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2020-12-06 07:16:59 UTC

FEDORA-2020-6aed90deb3 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6aed90deb3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6aed90deb3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-12-10 01:15:08 UTC

FEDORA-2020-6aed90deb3 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.